Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: runtime/vm/metrics.h

Issue 2572873003: Add --print-benchmarking-metrics to the VM for Golem. (Closed)
Patch Set: metric Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/metrics.h
diff --git a/runtime/vm/metrics.h b/runtime/vm/metrics.h
index fd4449bcabb241281731b43cdcba31bd9a363ef6..6e96170ace99f332afadd0e0a0dd9526ffd0d5f8 100644
--- a/runtime/vm/metrics.h
+++ b/runtime/vm/metrics.h
@@ -25,16 +25,20 @@ class JSONStream;
V(MaxMetric, HeapNewCapacityMax, "heap.new.capacity.max", kByte) \
V(MetricHeapNewExternal, HeapNewExternal, "heap.new.external", kByte) \
V(MetricHeapUsed, HeapGlobalUsed, "heap.global.used", kByte) \
- V(MaxMetric, HeapGlobalUsedMax, "heap.global.used.max", kByte)
+ V(MaxMetric, HeapGlobalUsedMax, "heap.global.used.max", kByte) \
+ V(Metric, RunnableLatency, "isolate.runnable.latency", kMicrosecond) \
+ V(Metric, RunnableHeapSize, "isolate.runnable.heap", kByte)
#define VM_METRIC_LIST(V) \
- V(MetricIsolateCount, IsolateCount, "vm.isolate.count", kCounter)
+ V(MetricIsolateCount, IsolateCount, "vm.isolate.count", kCounter) \
+ V(MetricPeakRSS, PeakRSS, "vm.memory.max", kByte)
class Metric {
public:
enum Unit {
kCounter,
kByte,
+ kMicrosecond,
};
Metric();
@@ -168,6 +172,12 @@ class MetricIsolateCount : public Metric {
};
+class MetricPeakRSS : public Metric {
+ protected:
+ virtual int64_t Value() const;
+};
+
+
class MetricHeapUsed : public Metric {
protected:
virtual int64_t Value() const;
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/metrics.cc » ('j') | runtime/vm/metrics.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698