Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: runtime/vm/dart.cc

Issue 2572873003: Add --print-benchmarking-metrics to the VM for Golem. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/flag_list.h » ('j') | runtime/vm/metrics.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 if (FLAG_support_timeline) { 478 if (FLAG_support_timeline) {
479 if (FLAG_trace_shutdown) { 479 if (FLAG_trace_shutdown) {
480 OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Shutting down timeline\n", 480 OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Shutting down timeline\n",
481 UptimeMillis()); 481 UptimeMillis());
482 } 482 }
483 Timeline::Shutdown(); 483 Timeline::Shutdown();
484 } 484 }
485 if (FLAG_trace_shutdown) { 485 if (FLAG_trace_shutdown) {
486 OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Done\n", UptimeMillis()); 486 OS::PrintErr("[+%" Pd64 "ms] SHUTDOWN: Done\n", UptimeMillis());
487 } 487 }
488 if (FLAG_print_benchmarking_metrics) {
489 OS::Print("PeakRSS(MemoryUse): %" Pd64 " B.\n", OS::MaxRSS());
Cutch 2016/12/16 21:49:07 This can just be a VM metric
490 }
488 491
489 return NULL; 492 return NULL;
490 } 493 }
491 494
492 495
493 Isolate* Dart::CreateIsolate(const char* name_prefix, 496 Isolate* Dart::CreateIsolate(const char* name_prefix,
494 const Dart_IsolateFlags& api_flags) { 497 const Dart_IsolateFlags& api_flags) {
495 // Create a new isolate. 498 // Create a new isolate.
496 Isolate* isolate = Isolate::Init(name_prefix, api_flags); 499 Isolate* isolate = Isolate::Init(name_prefix, api_flags);
497 return isolate; 500 return isolate;
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
738 return predefined_handles_->handles_.IsValidScopedHandle(address); 741 return predefined_handles_->handles_.IsValidScopedHandle(address);
739 } 742 }
740 743
741 744
742 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 745 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
743 ASSERT(predefined_handles_ != NULL); 746 ASSERT(predefined_handles_ != NULL);
744 return predefined_handles_->api_handles_.IsValidHandle(handle); 747 return predefined_handles_->api_handles_.IsValidHandle(handle);
745 } 748 }
746 749
747 } // namespace dart 750 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flag_list.h » ('j') | runtime/vm/metrics.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698