Add --print-benchmarking-metrics to the VM for Golem.

Add --print-benchmarking-metrics to the VM for Golem.

R=fschneider@google.com, johnmccutchan@google.com, sortie@google.com

Committed: https://github.com/dart-lang/sdk/commit/1688aa810ec66d3986e1d0d49611ba7e96a3d2c2

[rmacnak, 2016-12-14 18:17:49]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, sortie@google.com

[rmacnak, 2016-12-14 18:17:50]

Looks like

$ ./out/ReleaseX64/dart --print-benchmarking-metrics
~/benchmarks/DeltaBlue/dart/DeltaBlue.dart 
MakeRunnable(Latency): 97909 us.
MakeRunnable(HeapSize): 1702032 B.
DeltaBlue(RunTime): 1103.2497606177606 us.
PeakRSS(MemoryUse): 57319424 B.

$ ./out/ReleaseX64/dart_bootstrap --print-benchmarking-metrics
--snapshot=DeltaBlue.aot --snapshot-kind=app-aot --use-blobs
~/benchmarks/DeltaBlue/dart/DeltaBlue.dart 
MakeRunnable(Latency): 367553 us.
MakeRunnable(HeapSize): 5241008 B.
PeakRSS(MemoryUse): 93483008 B.

$ ./out/ReleaseX64/dart_precompiled_runtime --print-benchmarking-metrics
DeltaBlue.aot MakeRunnable(Latency): 8410 us.
MakeRunnable(HeapSize): 2342576 B.
DeltaBlue(RunTime): 4670.336839160838 us.
PeakRSS(MemoryUse): 31236096 B.

[Florian Schneider, 2016-12-14 18:22:47]

lgtm

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:127: "Print metrics used by continuous benchmarking.")   
                      \
"Print additional metrics about the main isolate."

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1182: if (!ServiceIsolate::NameEquals(name())) {
Maybe only print the metrics for the main isolate?

[Cutch, 2016-12-14 18:34:36]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-12-14 18:34:36]

DBC

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1189: OS::Print("MakeRunnable(Latency): %" Pd64 " us.\n",
uptime);
Please use the metric support in metrics.h instead of rolling your own.

[sortie, 2016-12-14 19:09:52]

The existence of Golem is not public though it has been leaked through sdk
commit messsages a couple of times

Otherwise lgtm

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1188: int64_t uptime = OS::GetCurrentTimeMicros() -
start_time();
This interval seems to be measure in wall seconds (subject to time changes, leap
second smearing, etc.) rather than monotonic time.

[rmacnak, 2016-12-16 19:10:22]

John, PTAL at use of metrics. Perhaps we also should have metric printing use
the same isolate filter as THR_Prints?

Output now looks like

./out/ReleaseX64/dart --print-benchmarking-metrics
~/benchmarks/DeltaBlue/dart/DeltaBlue.dart 
DeltaBlue(RunTime): 1087.2826402173912 us.
Printing metrics for DeltaBlue.dart$main-885587317
heap.old.used 0.000 B (0 B)
heap.old.used.max 2.047 MB (2145984 B)
heap.old.capacity 0.000 B (0 B)
heap.old.capacity.max 2.750 MB (2883584 B)
heap.old.external 0.000 B (0 B)
heap.new.used 0.000 B (0 B)
heap.new.used.max 54.141 kB (55440 B)
heap.new.capacity 0.000 B (0 B)
heap.new.capacity.max 8.000 MB (8388608 B)
heap.new.external 0.000 B (0 B)
heap.global.used 0.000 B (0 B)
heap.global.used.max 2.560 MB (2684064 B)
isolate.runnable.latency 114.299 ms (114299 us)
isolate.runnable.heap 1.623 MB (1702224 B)

Printing metrics for VM
vm.isolate.count 0

Printing metrics for vm-service
heap.old.used 0.000 B (0 B)
heap.old.used.max 1.479 MB (1551040 B)
heap.old.capacity 0.000 B (0 B)
heap.old.capacity.max 4.000 MB (4194304 B)
heap.old.external 0.000 B (0 B)
heap.new.used 0.000 B (0 B)
heap.new.used.max 69.812 kB (71488 B)
heap.new.capacity 0.000 B (0 B)
heap.new.capacity.max 8.000 MB (8388608 B)
heap.new.external 0.000 B (0 B)
heap.global.used 0.000 B (0 B)
heap.global.used.max 1.629 MB (1707664 B)
isolate.runnable.latency 8.687 ms (8687 us)
isolate.runnable.heap 1.113 MB (1167424 B)

Printing metrics for vm-isolate-28127723
heap.old.used 0.000 B (0 B)
heap.old.used.max 0.000 B (0 B)
heap.old.capacity 0.000 B (0 B)
heap.old.capacity.max 1.832 MB (1921024 B)
heap.old.external 0.000 B (0 B)
heap.new.used 0.000 B (0 B)
heap.new.used.max 0.000 B (0 B)
heap.new.capacity 0.000 B (0 B)
heap.new.capacity.max 0.000 B (0 B)
heap.new.external 0.000 B (0 B)
heap.global.used 0.000 B (0 B)
heap.global.used.max 0.000 B (0 B)
isolate.runnable.latency 0.000 us (0 us)
isolate.runnable.heap 0.000 B (0 B)

PeakRSS(MemoryUse): 62238720 B.

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/2572873003/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:127: "Print metrics used by continuous benchmarking.")   
                      \
On 2016/12/14 18:22:47, Florian Schneider wrote:
> "Print additional metrics about the main isolate."

Done.

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2572873003/diff/20001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1188: int64_t uptime = OS::GetCurrentTimeMicros() -
start_time();
On 2016/12/14 19:09:52, sortie wrote:
> This interval seems to be measure in wall seconds (subject to time changes,
leap
> second smearing, etc.) rather than monotonic time.

Fixed this in another CL.

[Cutch, 2016-12-16 21:43:34]

On 2016/12/16 19:10:22, rmacnak wrote:
> John, PTAL at use of metrics. Perhaps we also should have metric printing use
> the same isolate filter as THR_Prints?
> 
> Output now looks like
> 
> ./out/ReleaseX64/dart --print-benchmarking-metrics
> ~/benchmarks/DeltaBlue/dart/DeltaBlue.dart 
> DeltaBlue(RunTime): 1087.2826402173912 us.
> Printing metrics for DeltaBlue.dart$main-885587317
> heap.old.used 0.000 B (0 B)
> heap.old.used.max 2.047 MB (2145984 B)
> heap.old.capacity 0.000 B (0 B)
> heap.old.capacity.max 2.750 MB (2883584 B)
> heap.old.external 0.000 B (0 B)
> heap.new.used 0.000 B (0 B)
> heap.new.used.max 54.141 kB (55440 B)
> heap.new.capacity 0.000 B (0 B)
> heap.new.capacity.max 8.000 MB (8388608 B)
> heap.new.external 0.000 B (0 B)
> heap.global.used 0.000 B (0 B)
> heap.global.used.max 2.560 MB (2684064 B)
> isolate.runnable.latency 114.299 ms (114299 us)
> isolate.runnable.heap 1.623 MB (1702224 B)
> 
> Printing metrics for VM
> vm.isolate.count 0
> 
> Printing metrics for vm-service
> heap.old.used 0.000 B (0 B)
> heap.old.used.max 1.479 MB (1551040 B)
> heap.old.capacity 0.000 B (0 B)
> heap.old.capacity.max 4.000 MB (4194304 B)
> heap.old.external 0.000 B (0 B)
> heap.new.used 0.000 B (0 B)
> heap.new.used.max 69.812 kB (71488 B)
> heap.new.capacity 0.000 B (0 B)
> heap.new.capacity.max 8.000 MB (8388608 B)
> heap.new.external 0.000 B (0 B)
> heap.global.used 0.000 B (0 B)
> heap.global.used.max 1.629 MB (1707664 B)
> isolate.runnable.latency 8.687 ms (8687 us)
> isolate.runnable.heap 1.113 MB (1167424 B)
> 
> Printing metrics for vm-isolate-28127723
> heap.old.used 0.000 B (0 B)
> heap.old.used.max 0.000 B (0 B)
> heap.old.capacity 0.000 B (0 B)
> heap.old.capacity.max 1.832 MB (1921024 B)
> heap.old.external 0.000 B (0 B)
> heap.new.used 0.000 B (0 B)
> heap.new.used.max 0.000 B (0 B)
> heap.new.capacity 0.000 B (0 B)
> heap.new.capacity.max 0.000 B (0 B)
> heap.new.external 0.000 B (0 B)
> heap.global.used 0.000 B (0 B)
> heap.global.used.max 0.000 B (0 B)
> isolate.runnable.latency 0.000 us (0 us)
> isolate.runnable.heap 0.000 B (0 B)
> 
> PeakRSS(MemoryUse): 62238720 B.
> 

Why isn't this also a VM metric?

[Cutch, 2016-12-16 21:49:07]

https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/dart.cc#newc...
runtime/vm/dart.cc:489: OS::Print("PeakRSS(MemoryUse): %" Pd64 " B.\n",
OS::MaxRSS());
This can just be a VM metric

https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/metrics.cc
File runtime/vm/metrics.cc (right):

https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/metrics.cc#n...
runtime/vm/metrics.cc:120: if (value > GB) {
nice fix.

[Cutch, 2017-01-31 17:09:14]

On 2016/12/16 21:49:07, Cutch wrote:
> https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/dart.cc
> File runtime/vm/dart.cc (right):
> 
>
https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/dart.cc#newc...
> runtime/vm/dart.cc:489: OS::Print("PeakRSS(MemoryUse): %" Pd64 " B.\n",
> OS::MaxRSS());
> This can just be a VM metric
> 
> https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/metrics.cc
> File runtime/vm/metrics.cc (right):
> 
>
https://codereview.chromium.org/2572873003/diff/40001/runtime/vm/metrics.cc#n...
> runtime/vm/metrics.cc:120: if (value > GB) {
> nice fix.

Ping?

[rmacnak, 2017-01-31 23:49:20]

sync'd + metric changed. John, PTAL.

https://codereview.chromium.org/2572873003/diff/80001/runtime/vm/metrics.cc
File runtime/vm/metrics.cc (right):

https://codereview.chromium.org/2572873003/diff/80001/runtime/vm/metrics.cc#n...
runtime/vm/metrics.cc:158: return zone->PrintToString("%s %s", name(),
ValueToString(Value(), unit()));
Forcing compute here.

[Cutch, 2017-01-31 23:50:56]

lgtm

https://codereview.chromium.org/2572873003/diff/80001/runtime/vm/metrics.cc
File runtime/vm/metrics.cc (right):

https://codereview.chromium.org/2572873003/diff/80001/runtime/vm/metrics.cc#n...
runtime/vm/metrics.cc:158: return zone->PrintToString("%s %s", name(),
ValueToString(Value(), unit()));
On 2017/01/31 23:49:19, rmacnak wrote:
> Forcing compute here.

Acknowledged.

[rmacnak, 2017-02-01 00:39:25]

Description was changed from

==========
Add --print-benchmarking-metrics to the VM for Golem.
==========

to

==========
Add --print-benchmarking-metrics to the VM for Golem.

R=fschneider@google.com, johnmccutchan@google.com, sortie@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1688aa810ec66d3986e1d0d49611ba7e96a3d2c2
==========

[rmacnak, 2017-02-01 00:39:27]

Committed patchset #5 (id:80001) manually as
1688aa810ec66d3986e1d0d49611ba7e96a3d2c2 (presubmit successful).