Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: extensions/browser/content_hash_fetcher.cc

Issue 2572833004: Only whitelist messages.json files in _locales for content verification (Closed)
Patch Set: turn on logging to try and understand win_chromium_x64_rel_ng test failures Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/content_hash_fetcher.cc
diff --git a/extensions/browser/content_hash_fetcher.cc b/extensions/browser/content_hash_fetcher.cc
index fda8d67f08832e8b6b30fc9a2f0ed77d825caa71..4079874dfe52b683d7af4e7a0196885d8f23ad02 100644
--- a/extensions/browser/content_hash_fetcher.cc
+++ b/extensions/browser/content_hash_fetcher.cc
@@ -236,11 +236,11 @@ void ContentHashFetcherJob::DoneCheckingForVerifiedContents(bool found) {
if (IsCancelled())
return;
if (found) {
- VLOG(1) << "Found verified contents for " << extension_id_;
+ LOG(WARNING) << "Found verified contents for " << extension_id_;
DoneFetchingVerifiedContents(true);
} else {
- VLOG(1) << "Missing verified contents for " << extension_id_
- << ", fetching...";
+ LOG(WARNING) << "Missing verified contents for " << extension_id_
+ << ", fetching...";
url_fetcher_ =
net::URLFetcher::Create(fetch_url_, net::URLFetcher::GET, this);
url_fetcher_->SetRequestContext(request_context_);
@@ -264,9 +264,9 @@ static int WriteFileHelper(const base::FilePath& path,
}
void ContentHashFetcherJob::OnURLFetchComplete(const net::URLFetcher* source) {
- VLOG(1) << "URLFetchComplete for " << extension_id_
- << " is_success:" << url_fetcher_->GetStatus().is_success() << " "
- << fetch_url_.possibly_invalid_spec();
+ LOG(WARNING) << "URLFetchComplete for " << extension_id_
+ << " is_success:" << url_fetcher_->GetStatus().is_success()
+ << " " << fetch_url_.possibly_invalid_spec();
if (IsCancelled())
return;
std::unique_ptr<std::string> response(new std::string);
@@ -282,7 +282,7 @@ void ContentHashFetcherJob::OnURLFetchComplete(const net::URLFetcher* source) {
// move to parsing this in a sandboxed helper (crbug.com/372878).
std::unique_ptr<base::Value> parsed(base::JSONReader::Read(*response));
if (parsed) {
- VLOG(1) << "JSON parsed ok for " << extension_id_;
+ LOG(WARNING) << "JSON parsed ok for " << extension_id_;
parsed.reset(); // no longer needed
base::FilePath destination =
@@ -401,7 +401,7 @@ bool ContentHashFetcherJob::CreateHashes(const base::FilePath& hashes_file) {
std::string root =
ComputeTreeHashRoot(hashes, block_size_ / crypto::kSHA256Length);
if (!verified_contents_->TreeHashRootEquals(relative_path, root)) {
- VLOG(1) << "content mismatch for " << relative_path.AsUTF8Unsafe();
+ LOG(WARNING) << "content mismatch for " << relative_path.AsUTF8Unsafe();
hash_mismatch_paths_.insert(relative_path);
continue;
}
« no previous file with comments | « chrome/test/data/extensions/content_verifier/content_script_locales.crx ('k') | extensions/browser/content_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698