Clang toolchain: checkout LLD on all platforms but Darwin.

tools/clang/scripts/update.py

Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index a51c515c6e6dd61097f1c85b642535227d501206..4b35ff7d8eb58251f5bd50f59b4abf3d6c46d87f 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -457,7 +457,8 @@ def UpdateClang(args):
 
   Checkout('LLVM', LLVM_REPO_URL + '/llvm/trunk', LLVM_DIR)
   Checkout('Clang', LLVM_REPO_URL + '/cfe/trunk', CLANG_DIR)
-  if sys.platform == 'win32' or use_head_revision:

[Nico, 2016/12/13 20:02:23]

Do we still need use_head_revision here now that we do this on Linux? I guess
the Mac tot bots currently build LLD but they probably shouldn't anyway.
use_head_revision is probably here 'cause you added it for the lld tot bot? (I
don't remember)

[krasin1, 2016/12/13 20:08:19]

It was Peter who set up the LLD ToT bot, but you're right about the intention. I
can invert the condition to sys.platform != 'darwin'. Would that be better?

[Nico, 2016/12/13 20:12:55]

I mean I think we can remove the use_head_revision bit now. I don't care if we
do `platform == win || platform == linux` or `platform != darwin`, those are
both fine.

(If we do do remove use_head_revision, we should probably have an else: branch
that deletes lld if it's there, to clean up the checkouts on the mac tot bots,
at least for a short while)

+  if (sys.platform == 'win32' or sys.platform.startswith('linux') or
+      use_head_revision):
     Checkout('LLD', LLVM_REPO_URL + '/lld/trunk', LLD_DIR)
   Checkout('compiler-rt', LLVM_REPO_URL + '/compiler-rt/trunk', COMPILER_RT_DIR)
   if sys.platform == 'darwin':