Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/analyzer/test/src/command_line/arguments_test.dart

Issue 2572813002: update DDC and analyzer cli preprocessArgs (Closed)
Patch Set: merge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/command_line/arguments.dart ('k') | pkg/analyzer_cli/lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/command_line/arguments_test.dart
diff --git a/pkg/analyzer/test/src/command_line/arguments_test.dart b/pkg/analyzer/test/src/command_line/arguments_test.dart
index eb6704c795d5f8c893bbc7def1df6411f499dbbf..17aff4141290ea36e0257e48d505ff3b557137f3 100644
--- a/pkg/analyzer/test/src/command_line/arguments_test.dart
+++ b/pkg/analyzer/test/src/command_line/arguments_test.dart
@@ -166,8 +166,10 @@ class ArgumentsTest {
void test_preprocessArgs_noReplacement() {
MemoryResourceProvider provider = new MemoryResourceProvider();
- List<String> result = preprocessArgs(provider, ['--xx' '--yy' 'baz']);
- expect(result, orderedEquals(['--xx' '--yy' 'baz']));
+ List<String> original = ['--xx' '--yy' 'baz'];
+ List<String> result = preprocessArgs(provider, original);
+ expect(result, orderedEquals(original));
+ expect(identical(original, result), isFalse);
}
void test_preprocessArgs_replacement_exists() {
@@ -191,8 +193,13 @@ bar
MemoryResourceProvider provider = new MemoryResourceProvider();
String filePath = provider.convertPath('/args.txt');
List<String> args = ['ignored', '@$filePath'];
- List<String> result = preprocessArgs(provider, args);
- expect(result, orderedEquals(args));
+ try {
+ preprocessArgs(provider, args);
+ fail('Expect exception');
+ } on Exception catch (e) {
+ expect(e.toString(), contains('Failed to read file'));
+ expect(e.toString(), contains('@$filePath'));
+ }
}
void test_preprocessArgs_replacement_notLast() {
« no previous file with comments | « pkg/analyzer/lib/src/command_line/arguments.dart ('k') | pkg/analyzer_cli/lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698