components/pageinfo_strings.grdp - Issue 2572773002: Add page info strings for offline pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pageinfo_strings.grdp

Issue 2572773002: Add page info strings for offline pages. (Closed)

Patch Set: remove space Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/pageinfo_strings.grdp

diff --git a/components/pageinfo_strings.grdp b/components/pageinfo_strings.grdp

index 36e825733e1429566f35ab3c49303b2f4735ac78..f749f60749f167033fcf566a63cab8848706bff7 100644

--- a/components/pageinfo_strings.grdp

+++ b/components/pageinfo_strings.grdp

@@ -71,4 +71,15 @@

Certificate Information

</message>

</if>

+ <if expr="is_ios">

rohitrao (ping after 24h) 2016/12/13 14:19:40 Should these live behind is_ios, or should they ju

jif-google 2016/12/13 14:29:14 The strings are not used by any other platform, so

Olivier 2016/12/13 14:37:00 The strings are never used from the components, so

+ <message name="IDS_PAGE_INFO_OFFLINE_PAGE" desc="Message to display in the page info bubble when the page you are on is an offline page.">

+ The page has been saved locally to your Reading List.

+ </message>

+ <message name="IDS_PAGE_INFO_OFFLINE_TITLE" desc="Title of the message to display in the page info bubble when the page you are on is an offline page.">

+ Viewing in Offline Mode

+ </message>

+ <message name="IDS_PAGE_INFO_RELOAD" desc="Button title in the page info bubble that allows to reload the current page.">

+ Reload

+ </message>

+ </if>

</grit-part>

« no previous file with comments | « no previous file | no next file » | no next file with comments »