Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257273002: Descend into inner tables for has-enough-text check. (Closed)

Created:
6 years, 7 months ago by skobes
Modified:
6 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, chrishtr, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, ojan, rune+blink
Visibility:
Public.

Description

Descend into inner tables for has-enough-text check. BUG=366136, 359788 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173043

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add a test. #

Patch Set 4 : Rebaseline. #

Patch Set 5 : Speculative fix for mac test failure. #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
A LayoutTests/fast/text-autosizing/nested-table.html View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/text-autosizing/nested-table-expected.html View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
skobes
Real world impact script showed no obvious regressions.
6 years, 7 months ago (2014-04-29 23:20:07 UTC) #1
pdr.
On 2014/04/29 23:20:07, skobes wrote: > Real world impact script showed no obvious regressions. LGTM ...
6 years, 7 months ago (2014-04-29 23:40:19 UTC) #2
skobes
On 2014/04/29 23:40:19, pdr wrote: > LGTM if you can check in a minimized version ...
6 years, 7 months ago (2014-04-30 20:47:33 UTC) #3
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 7 months ago (2014-04-30 20:47:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/257273002/60001
6 years, 7 months ago (2014-04-30 20:48:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 21:29:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 21:29:02 UTC) #7
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 7 months ago (2014-04-30 22:46:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/257273002/80001
6 years, 7 months ago (2014-04-30 22:47:01 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 23:17:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 23:17:13 UTC) #11
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 7 months ago (2014-04-30 23:24:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/257273002/100001
6 years, 7 months ago (2014-04-30 23:25:02 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 23:52:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 23:52:45 UTC) #15
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 7 months ago (2014-04-30 23:53:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/257273002/100001
6 years, 7 months ago (2014-04-30 23:53:44 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 00:33:39 UTC) #18
Message was sent while issue was closed. 
Change committed as 173043

Powered by Google App Engine
This is Rietveld 408576698