Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: gpu/ipc/client/gpu_memory_buffer_impl.h

Issue 2572703004: exo: Directly create GpuMemoryBufferImpl when a handle is available. (Closed)
Patch Set: null callback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gpu_memory_buffer_manager.h ('k') | gpu/ipc/client/gpu_memory_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/ipc/client/gpu_memory_buffer_impl.h
diff --git a/gpu/ipc/client/gpu_memory_buffer_impl.h b/gpu/ipc/client/gpu_memory_buffer_impl.h
index a8dc56b7e3ad0a3ed0f09efd24cb6fc985be87f8..43e23e34bc553093dca41bda2bf42b8e2dad96dc 100644
--- a/gpu/ipc/client/gpu_memory_buffer_impl.h
+++ b/gpu/ipc/client/gpu_memory_buffer_impl.h
@@ -24,9 +24,9 @@ class GPU_EXPORT GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
~GpuMemoryBufferImpl() override;
// Creates an instance from the given |handle|. |size| and |internalformat|
- // should match what was used to allocate the |handle|. |callback| is
- // called when instance is deleted, which is not necessarily on the same
- // thread as this function was called on and instance was created on.
+ // should match what was used to allocate the |handle|. |callback|, if
+ // non-null, is called when instance is deleted, which is not necessarily on
+ // the same thread as this function was called on and instance was created on.
static std::unique_ptr<GpuMemoryBufferImpl> CreateFromHandle(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
« no previous file with comments | « gpu/command_buffer/client/gpu_memory_buffer_manager.h ('k') | gpu/ipc/client/gpu_memory_buffer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698