Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 25727009: Revert 226762 "Android perf tests: kill adbd on the device after..." (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 2 months ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226762 "Android perf tests: kill adbd on the device after..." This seems to make matters worse on sharded bots. Possibly because killing adbd on one device affects the host's adb connection with other devices. > Android perf tests: kill adbd on the device after running a test. > > There's some data indicating that adbd on the device sometimes > spontaneously restores its connection. > After running a test, let's kill adbd and wait for bit. > > This is a speculative change to try to make the bots healthier. > > BUG= > > Review URL: https://codereview.chromium.org/25574002 TBR=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M trunk/src/build/android/pylib/android_commands.py View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/build/android/pylib/perf/test_runner.py View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmcilroy
7 years, 2 months ago (2013-10-04 09:51:24 UTC) #1
rmcilroy
7 years, 2 months ago (2013-10-04 09:51:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r226980.

Powered by Google App Engine
This is Rietveld 408576698