Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Unified Diff: chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc

Issue 2572683004: mediaview: Introduce ArcDocumentsProviderRoot. (Closed)
Patch Set: Constructors are called on the UI thread. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc b/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc
index d14a96ac86b43c395a1063f0562ab92a9c412e50..1f988dbe2d1cd0eeffe845fb9a96dd5ee92dd83f 100644
--- a/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc
+++ b/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.cc
@@ -4,19 +4,26 @@
#include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_async_file_util.h"
-#include "base/callback.h"
+#include <utility>
+
#include "base/files/file.h"
#include "base/files/file_path.h"
#include "base/logging.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_map.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h"
#include "content/public/browser/browser_thread.h"
#include "storage/browser/blob/shareable_file_reference.h"
+#include "storage/browser/fileapi/file_system_operation_context.h"
+#include "storage/browser/fileapi/file_system_url.h"
using content::BrowserThread;
namespace arc {
-ArcDocumentsProviderAsyncFileUtil::ArcDocumentsProviderAsyncFileUtil() =
- default;
+ArcDocumentsProviderAsyncFileUtil::ArcDocumentsProviderAsyncFileUtil(
+ ArcDocumentsProviderRootMap* roots)
+ : roots_(roots) {}
ArcDocumentsProviderAsyncFileUtil::~ArcDocumentsProviderAsyncFileUtil() =
default;
@@ -59,8 +66,16 @@ void ArcDocumentsProviderAsyncFileUtil::GetFileInfo(
int fields,
const GetFileInfoCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- NOTIMPLEMENTED(); // TODO(crbug.com/671511): Implement this function.
- callback.Run(base::File::FILE_ERROR_NOT_FOUND, base::File::Info());
+ DCHECK_EQ(storage::kFileSystemTypeArcDocumentsProvider, url.type());
+
+ base::FilePath path;
+ ArcDocumentsProviderRoot* root = roots_->ParseAndLookup(url, &path);
+ if (!root) {
+ callback.Run(base::File::FILE_ERROR_NOT_FOUND, base::File::Info());
+ return;
+ }
+
+ root->GetFileInfo(path, callback);
}
void ArcDocumentsProviderAsyncFileUtil::ReadDirectory(
@@ -68,9 +83,16 @@ void ArcDocumentsProviderAsyncFileUtil::ReadDirectory(
const storage::FileSystemURL& url,
const ReadDirectoryCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- NOTIMPLEMENTED(); // TODO(crbug.com/671511): Implement this function.
- callback.Run(base::File::FILE_ERROR_NOT_FOUND, EntryList(),
- false /* has_more */);
+ DCHECK_EQ(storage::kFileSystemTypeArcDocumentsProvider, url.type());
+
+ base::FilePath path;
+ ArcDocumentsProviderRoot* root = roots_->ParseAndLookup(url, &path);
+ if (!root) {
+ callback.Run(base::File::FILE_ERROR_NOT_FOUND, EntryList(), false);
+ return;
+ }
+
+ root->ReadDirectory(path, callback);
}
void ArcDocumentsProviderAsyncFileUtil::Touch(

Powered by Google App Engine
This is Rietveld 408576698