Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2572603003: Implement SearchEngine.searchTopLevelDeclarations() for the new driver. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement SearchEngine.searchTopLevelDeclarations() for the new driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/142473b8cb211c4af79096cb0d736e0922fb6610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -27 lines) Patch
M pkg/analysis_server/lib/src/services/search/search_engine_internal2.dart View 1 chunk +18 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 2 chunks +47 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/search.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 3 chunks +44 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years ago (2016-12-13 19:30:21 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-13 19:41:02 UTC) #2
scheglov
4 years ago (2016-12-13 20:11:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
142473b8cb211c4af79096cb0d736e0922fb6610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698