Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

Issue 2572603002: ABANDONED CL: Rename readyState() to getReadyState(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 bool isResultDirty() const { return m_resultDirty; } 75 bool isResultDirty() const { return m_resultDirty; }
76 IDBAny* resultAsAny() const { return m_result; } 76 IDBAny* resultAsAny() const { return m_result; }
77 77
78 // Requests made during index population are implementation details and so 78 // Requests made during index population are implementation details and so
79 // events should not be visible to script. 79 // events should not be visible to script.
80 void preventPropagation() { m_preventPropagation = true; } 80 void preventPropagation() { m_preventPropagation = true; }
81 81
82 // Defined in the IDL 82 // Defined in the IDL
83 enum ReadyState { PENDING = 1, DONE = 2, EarlyDeath = 3 }; 83 enum ReadyState { PENDING = 1, DONE = 2, EarlyDeath = 3 };
84 84
85 const String& readyState() const; 85 const String& getReadyState() const;
Łukasz Anforowicz 2016/12/12 22:43:49 After naive rename this would conflict with IDBReq
86 86
87 // Returns a new WebIDBCallbacks for this request. Must only be called once. 87 // Returns a new WebIDBCallbacks for this request. Must only be called once.
88 std::unique_ptr<WebIDBCallbacks> createWebCallbacks(); 88 std::unique_ptr<WebIDBCallbacks> createWebCallbacks();
89 void webCallbacksDestroyed(); 89 void webCallbacksDestroyed();
90 90
91 DEFINE_ATTRIBUTE_EVENT_LISTENER(success); 91 DEFINE_ATTRIBUTE_EVENT_LISTENER(success);
92 DEFINE_ATTRIBUTE_EVENT_LISTENER(error); 92 DEFINE_ATTRIBUTE_EVENT_LISTENER(error);
93 93
94 void setCursorDetails(IndexedDB::CursorType, WebIDBCursorDirection); 94 void setCursorDetails(IndexedDB::CursorType, WebIDBCursorDirection);
95 void setPendingCursor(IDBCursor*); 95 void setPendingCursor(IDBCursor*);
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 bool m_resultDirty = true; 188 bool m_resultDirty = true;
189 189
190 // Pointer back to the WebIDBCallbacks that holds a persistent reference to 190 // Pointer back to the WebIDBCallbacks that holds a persistent reference to
191 // this object. 191 // this object.
192 WebIDBCallbacks* m_webCallbacks = nullptr; 192 WebIDBCallbacks* m_webCallbacks = nullptr;
193 }; 193 };
194 194
195 } // namespace blink 195 } // namespace blink
196 196
197 #endif // IDBRequest_h 197 #endif // IDBRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698