Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2572593002: [counting_allocator] Chrome changes.

Created:
4 years ago by DmitrySkiba
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org, tracing+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[counting_allocator] Chrome changes. To get it building you need to apply more patches: Android: * https://chromium-review.googlesource.com/#/c/419077 to third_party/android_tools/ndk/ macOS: * https://codereview.chromium.org/2570443003 to buildtools/ * (OUTDATED, needs recent changes from Android's CL) https://codereview.chromium.org/2574553002 to buildtools/third_party/libc++/trunk/

Patch Set 1 #

Patch Set 2 : Surface max_size; instrument flat_set. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -25 lines) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/allocator/allocator_shim.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M base/allocator/allocator_shim.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M base/allocator/allocator_shim_override_cpp_symbols.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M base/containers/flat_set.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/containers/hash_tables.h View 2 chunks +13 lines, -4 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M base/trace_event/malloc_dump_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 1 6 chunks +72 lines, -1 line 0 comments Download
M build/config/android/BUILD.gn View 1 1 chunk +13 lines, -9 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +10 lines, -2 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
DmitrySkiba
Description was changed from ========== [counting_allocator] Chrome changes. ========== to ========== [counting_allocator] Chrome changes. To ...
4 years ago (2016-12-12 21:50:29 UTC) #1
DmitrySkiba
Description was changed from ========== [counting_allocator] Chrome changes. To get it building you need to ...
4 years ago (2016-12-12 21:58:25 UTC) #2
DmitrySkiba
Description was changed from ========== [counting_allocator] Chrome changes. To get it building you need to ...
4 years ago (2016-12-12 21:58:40 UTC) #3
DmitrySkiba
3 years, 9 months ago (2017-03-27 16:55:04 UTC) #4 
Description was changed from

==========
[counting_allocator] Chrome changes.

To get it building you need to apply more patches:

Android:
* https://chromium-review.googlesource.com/#/c/419077 to
third_party/android_tools/ndk/

macOS:
* https://codereview.chromium.org/2570443003 to buildtools/
* https://codereview.chromium.org/2574553002 to
buildtools/third_party/libc++/trunk/
==========

to

==========
[counting_allocator] Chrome changes.

To get it building you need to apply more patches:

Android:
* https://chromium-review.googlesource.com/#/c/419077 to
third_party/android_tools/ndk/

macOS:
* https://codereview.chromium.org/2570443003 to buildtools/
* (OUTDATED, needs recent changes from Android's CL)
https://codereview.chromium.org/2574553002 to
buildtools/third_party/libc++/trunk/
==========

Powered by Google App Engine
This is Rietveld 408576698