Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2572573007: Use passthrough decoder for (E)AC3 formats (Closed)
Patch Set: Use BitReader to unpack header fileds Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index 714536822b5e22adac0dd4ad2c11125cc210c0a6..f7d892b1dcca5950b460f2fc8aa498de2d5bafc9 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -117,6 +117,14 @@ static bool HasHevcSupport() {
#endif // BUILDFLAG(ENABLE_HEVC_DEMUXING)
}
+static bool HasEac3Support() {
+#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
+ return true;
+#else
+ return false;
+#endif
+}
+
TEST(MimeUtilTest, CommonMediaMimeType) {
EXPECT_TRUE(IsSupportedMediaMimeType("audio/webm"));
EXPECT_TRUE(IsSupportedMediaMimeType("video/webm"));
@@ -254,8 +262,6 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
switch (codec) {
// These codecs are never supported by the Android platform.
case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
case MimeUtil::MPEG2_AAC:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
@@ -288,6 +294,11 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
case MimeUtil::HEVC:
EXPECT_EQ(HasHevcSupport(), result);
break;
+
+ case MimeUtil::AC3:
+ case MimeUtil::EAC3:
+ EXPECT_EQ(HasEac3Support(), result);
+ break;
}
});
}
@@ -309,8 +320,6 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
switch (codec) {
// These codecs are never supported by the Android platform.
case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
case MimeUtil::MPEG2_AAC:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
@@ -340,6 +349,11 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
case MimeUtil::HEVC:
EXPECT_EQ(HasHevcSupport(), result);
break;
+
+ case MimeUtil::AC3:
+ case MimeUtil::EAC3:
+ EXPECT_EQ(HasEac3Support(), result);
+ break;
}
});
@@ -371,8 +385,6 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithUnifiedPipeline) {
switch (codec) {
// These codecs are never supported by the Android platform.
case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
break;
@@ -398,6 +410,11 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithUnifiedPipeline) {
case MimeUtil::HEVC:
EXPECT_EQ(HasHevcSupport() && info.has_platform_decoders, result);
break;
+
+ case MimeUtil::AC3:
+ case MimeUtil::EAC3:
+ EXPECT_EQ(HasEac3Support(), result);
+ break;
}
});
}

Powered by Google App Engine
This is Rietveld 408576698