Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: media/base/mime_util_unittest.cc

Issue 2572573007: Use passthrough decoder for (E)AC3 formats (Closed)
Patch Set: Sanity checks Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mime_util_internal.cc ('k') | media/filters/android/media_codec_audio_decoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index a23d9da6fea0b91d61254eef75628d50e4366764..efc86d161a4fc37cf19b84968533cfd4844349cd 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -124,6 +124,14 @@ static bool HasDolbyVisionSupport() {
return false;
}
+static bool HasEac3Support() {
+#if BUILDFLAG(ENABLE_AC3_EAC3_AUDIO_DEMUXING)
+ return true;
+#else
+ return false;
+#endif
+}
+
TEST(MimeUtilTest, CommonMediaMimeType) {
EXPECT_TRUE(IsSupportedMediaMimeType("audio/webm"));
EXPECT_TRUE(IsSupportedMediaMimeType("video/webm"));
@@ -274,8 +282,6 @@ TEST(IsCodecSupportedOnAndroidTest, EncryptedCodecBehavior) {
switch (codec) {
// These codecs are never supported by the Android platform.
case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
case MimeUtil::MPEG2_AAC:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
@@ -312,6 +318,11 @@ TEST(IsCodecSupportedOnAndroidTest, EncryptedCodecBehavior) {
case MimeUtil::DOLBY_VISION:
EXPECT_EQ(HasDolbyVisionSupport(), result);
break;
+
+ case MimeUtil::AC3:
+ case MimeUtil::EAC3:
+ EXPECT_EQ(HasEac3Support(), result);
+ break;
}
});
}
@@ -329,8 +340,6 @@ TEST(IsCodecSupportedOnAndroidTest, ClearCodecBehavior) {
switch (codec) {
// These codecs are never supported by the Android platform.
case MimeUtil::INVALID_CODEC:
- case MimeUtil::AC3:
- case MimeUtil::EAC3:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
break;
@@ -357,6 +366,11 @@ TEST(IsCodecSupportedOnAndroidTest, ClearCodecBehavior) {
case MimeUtil::DOLBY_VISION:
EXPECT_EQ(HasDolbyVisionSupport(), result);
break;
+
+ case MimeUtil::AC3:
+ case MimeUtil::EAC3:
+ EXPECT_EQ(HasEac3Support(), result);
+ break;
}
});
}
« no previous file with comments | « media/base/mime_util_internal.cc ('k') | media/filters/android/media_codec_audio_decoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698