Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2572573003: Remove old diagnostic crash reports. (Closed)
Patch Set: Preserve routing ID. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 0e80165d72ae40dd26db592606a2288f3ba6bbb1..c1be50590329cd60b632b58982b3b7eebb911d1b 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -276,14 +276,6 @@ bool RenderViewHostImpl::CreateRenderView(
CHECK(main_frame_routing_id_ != MSG_ROUTING_NONE ||
proxy_route_id != MSG_ROUTING_NONE);
- // We should not set both main_frame_routing_id_ and proxy_route_id. Log
- // cases that this happens (without crashing) to track down
- // https://crbug.com/575245.
- // TODO(creis): Remove this once we've found the cause.
- if (main_frame_routing_id_ != MSG_ROUTING_NONE &&
- proxy_route_id != MSG_ROUTING_NONE)
alexmos 2016/12/13 20:28:55 Would there be value in keeping this as a DCHECK?
Charlie Reis 2017/05/09 16:42:26 Sure, we can keep it as a DCHECK here.
- base::debug::DumpWithoutCrashing();
-
GetWidget()->set_renderer_initialized(true);
mojom::CreateViewParamsPtr params = mojom::CreateViewParams::New();

Powered by Google App Engine
This is Rietveld 408576698