Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4616)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2572573003: Remove old diagnostic crash reports. (Closed)
Patch Set: Restore RenderViewHostImpl dump Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 42ee8bc75ae27ee8f7c2818f27a2b4536c46e797..527e05f3ac7cd4e764e3a4ef5c2ca0bd43df9399 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -2018,33 +2018,8 @@ bool RenderFrameHostManager::InitRenderFrame(
if (existing_proxy) {
proxy_routing_id = existing_proxy->GetRoutingID();
CHECK_NE(proxy_routing_id, MSG_ROUTING_NONE);
- if (!existing_proxy->is_render_frame_proxy_live()) {
- // Calling InitRenderFrameProxy on main frames seems to be causing
- // https://crbug.com/575245, so track down how this can happen.
- // TODO(creis): Remove this once we've found the cause.
- if (!frame_tree_node_->parent()) {
- base::debug::SetCrashKeyValue(
- "initrf_frame_id",
- base::IntToString(render_frame_host->GetRoutingID()));
- base::debug::SetCrashKeyValue("initrf_proxy_id",
- base::IntToString(proxy_routing_id));
- base::debug::SetCrashKeyValue(
- "initrf_view_id",
- base::IntToString(
- render_frame_host->render_view_host()->GetRoutingID()));
- base::debug::SetCrashKeyValue(
- "initrf_main_frame_id",
- base::IntToString(render_frame_host->render_view_host()
- ->main_frame_routing_id()));
- base::debug::SetCrashKeyValue(
- "initrf_view_is_live",
- render_frame_host->render_view_host()->IsRenderViewLive() ? "yes"
- : "no");
- base::debug::DumpWithoutCrashing();
- }
-
+ if (!existing_proxy->is_render_frame_proxy_live())
existing_proxy->InitRenderFrameProxy();
- }
}
// TODO(alexmos): These crash keys are temporary to track down
« no previous file with comments | « chromecast/crash/cast_crash_keys.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698