Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2572573003: Remove old diagnostic crash reports. (Closed)
Patch Set: Fix typo. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 4fd32bcea7af8e9b0bf3fded1823f47358f69111..b364a51ccf27949a3d63a046d4c810e53f401fa8 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/command_line.h"
-#include "base/debug/dump_without_crashing.h"
#include "base/feature_list.h"
#include "base/i18n/rtl.h"
#include "base/json/json_reader.h"
@@ -278,13 +277,9 @@ bool RenderViewHostImpl::CreateRenderView(
CHECK(main_frame_routing_id_ != MSG_ROUTING_NONE ||
proxy_route_id != MSG_ROUTING_NONE);
- // We should not set both main_frame_routing_id_ and proxy_route_id. Log
- // cases that this happens (without crashing) to track down
- // https://crbug.com/575245.
- // TODO(creis): Remove this once we've found the cause.
- if (main_frame_routing_id_ != MSG_ROUTING_NONE &&
- proxy_route_id != MSG_ROUTING_NONE)
- base::debug::DumpWithoutCrashing();
+ // We should not set both main_frame_routing_id_ and proxy_route_id.
+ DCHECK(main_frame_routing_id_ == MSG_ROUTING_NONE ||
+ proxy_route_id == MSG_ROUTING_NONE);
GetWidget()->set_renderer_initialized(true);

Powered by Google App Engine
This is Rietveld 408576698