Remove old diagnostic crash reports.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
-#include "base/debug/crash_logging.h"
 #include "base/files/file_path.h"
 #include "base/i18n/rtl.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/location.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/process/kill.h"
 #include "base/process/process.h"
@@ skipping 562 matching lines @@
 
   g_view_map.Get().insert(std::make_pair(webview(), this));
   g_routing_id_view_map.Get().insert(std::make_pair(GetRoutingID(), this));
 
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
 
   if (command_line.HasSwitch(switches::kStatsCollectionController))
     stats_collection_observer_.reset(new StatsCollectionObserver(this));
 
-  // Debug cases of https://crbug.com/575245.
-  base::debug::SetCrashKeyValue("rvinit_view_id",

[alexmos, 2016/12/13 20:28:55]

I'll mention that there was some value in looking at these ones in the crash
dumps while debugging some of the other crashes, such as
https://crbug.com/626802.   It's probably ok to still remove them, and we can
re-add them if we need them again under the right bug.

[Charlie Reis, 2017/05/09 16:42:26]

Fair point, but I think it's worth trying to clean them up if we can.  As you
mention, we can add them back if needed for another investigation.

-                                base::IntToString(GetRoutingID()));
-  base::debug::SetCrashKeyValue("rvinit_proxy_id",
-                                base::IntToString(params.proxy_routing_id));
-  base::debug::SetCrashKeyValue(
-      "rvinit_main_frame_id", base::IntToString(params.main_frame_routing_id));
-
   webview()->setDisplayMode(display_mode_);
   webview()->settings()->setPreferCompositingToLCDTextEnabled(
       PreferCompositingToLCDText(compositor_deps_, device_scale_factor_));
   webview()->settings()->setThreadedScrollingEnabled(
       !command_line.HasSwitch(switches::kDisableThreadedScrolling));
   webview()->setShowFPSCounter(
       command_line.HasSwitch(cc::switches::kShowFPSCounter));
 
   if (auto overridden_color_profile =
           GetContentClient()->renderer()->GetImageDecodeColorProfile()) {
@@ skipping 2201 matching lines @@
                             INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
   }
 
   std::unique_ptr<InputEventAck> ack(
       new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type,
                         INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
   OnInputEventAck(std::move(ack));
 }
 
 }  // namespace content