Remove old diagnostic crash reports.

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 1949 matching lines @@
   // the proxy it is replacing, so that it can fully initialize itself.
   // NOTE: This is the only time that a RenderFrameProxyHost can be in the same
   // SiteInstance as its RenderFrameHost. This is only the case until the
   // RenderFrameHost commits, at which point it will replace and delete the
   // RenderFrameProxyHost.
   int proxy_routing_id = MSG_ROUTING_NONE;
   RenderFrameProxyHost* existing_proxy = GetRenderFrameProxyHost(site_instance);
   if (existing_proxy) {
     proxy_routing_id = existing_proxy->GetRoutingID();
     CHECK_NE(proxy_routing_id, MSG_ROUTING_NONE);
-    if (!existing_proxy->is_render_frame_proxy_live()) {
-      // Calling InitRenderFrameProxy on main frames seems to be causing
-      // https://crbug.com/575245, so track down how this can happen.
-      // TODO(creis): Remove this once we've found the cause.
-      if (!frame_tree_node_->parent()) {
-        base::debug::SetCrashKeyValue(
-            "initrf_frame_id",
-            base::IntToString(render_frame_host->GetRoutingID()));
-        base::debug::SetCrashKeyValue("initrf_proxy_id",
-                                      base::IntToString(proxy_routing_id));
-        base::debug::SetCrashKeyValue(
-            "initrf_view_id",
-            base::IntToString(
-                render_frame_host->render_view_host()->GetRoutingID()));
-        base::debug::SetCrashKeyValue(
-            "initrf_main_frame_id",
-            base::IntToString(render_frame_host->render_view_host()
-                                  ->main_frame_routing_id()));
-        base::debug::SetCrashKeyValue(
-            "initrf_view_is_live",
-            render_frame_host->render_view_host()->IsRenderViewLive() ? "yes"
-                                                                      : "no");
-        base::debug::DumpWithoutCrashing();

[alexmos, 2016/12/13 20:28:55]

Looks like this one is still happening (e.g., fa1ecae300000000 in 57.0.2948.0),
but I don't think getting here means that we've hit a bug.  I think this should
be safe to remove.  (Most of the InitRenderFrame DWOC's are actually from below,
for the CreateFrame bug which is still active, though there's a chance that
Lucas's CL might fix it.)

[Charlie Reis, 2017/05/09 16:42:25]

Yes, let's remove it-- I'm not convinced we're getting value from it.

-      }
-
+    if (!existing_proxy->is_render_frame_proxy_live())
       existing_proxy->InitRenderFrameProxy();
-    }
   }
 
   // TODO(alexmos): These crash keys are temporary to track down
   // https://crbug.com/591478. Verify that the parent routing ID
   // points to a live RenderFrameProxy when this is not a remote-to-local
   // navigation (i.e., when there's no |existing_proxy|).
   if (!existing_proxy && frame_tree_node_->parent()) {
     RenderFrameProxyHost* parent_proxy = RenderFrameProxyHost::FromID(
         render_frame_host->GetProcess()->GetID(), parent_routing_id);
     if (!parent_proxy || !parent_proxy->is_render_frame_proxy_live()) {
@@ skipping 729 matching lines @@
                                              resolved_url)) {
     DCHECK(!dest_instance ||
            dest_instance == render_frame_host_->GetSiteInstance());
     return false;
   }
 
   return true;
 }
 
 }  // namespace content