Remove old diagnostic crash reports.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 1756 matching lines @@
   // start using the RenderFrameProxy.
   //
   // The swap call deletes this RenderFrame via frameDetached.  Do not access
   // any members after this call.
   //
   // TODO(creis): WebFrame::swap() can return false.  Most of those cases
   // should be due to the frame being detached during unload (in which case
   // the necessary cleanup has happened anyway), but it might be possible for
   // it to return false without detaching.  Catch any cases that the
   // RenderView's main_render_frame_ isn't cleared below (whether swap returns
-  // false or not), to track down https://crbug.com/575245.
+  // false or not).
   bool success = frame_->Swap(proxy->web_frame());
 
   // For main frames, the swap should have cleared the RenderView's pointer to
   // this frame.
-  if (is_main_frame) {
-    base::debug::SetCrashKeyValue("swapout_frame_id",
-                                  base::IntToString(routing_id));
-    base::debug::SetCrashKeyValue("swapout_proxy_id",
-                                  base::IntToString(proxy->routing_id()));
-    base::debug::SetCrashKeyValue(
-        "swapout_view_id", base::IntToString(render_view->GetRoutingID()));
+  if (is_main_frame)
     CHECK(!render_view->main_render_frame_);
-  }
 
   if (!success) {
     // The swap can fail when the frame is detached during swap (this can
     // happen while running the unload handlers). When that happens, delete
     // the proxy.
     proxy->FrameDetached(blink::WebRemoteFrameClient::DetachType::kSwap);
     return;
   }
 
   if (is_loading)
@@ skipping 3334 matching lines @@
   // LocalFrame was being navigated, the provisional frame would've been
   // cleaned up by RenderFrameProxy::frameDetached.  See
   // https://crbug.com/526304 and https://crbug.com/568676 for context.
   RenderFrameProxy* proxy = RenderFrameProxy::FromRoutingID(proxy_routing_id_);
   CHECK(proxy);
 
   unique_name_helper_.set_propagated_name(proxy->unique_name());
 
   // Note: Calling swap() will detach and delete |proxy|, so do not reference it
   // after this.
-  int proxy_routing_id = proxy_routing_id_;
   if (!proxy->web_frame()->Swap(frame_))
     return false;
 
   proxy_routing_id_ = MSG_ROUTING_NONE;
   in_frame_tree_ = true;
 
   // If this is the main frame going from a remote frame to a local frame,
   // it needs to set RenderViewImpl's pointer for the main frame to itself
   // and ensure RenderWidget is no longer in swapped out mode.
   if (is_main_frame_) {
-    // Debug cases of https://crbug.com/575245.
-    base::debug::SetCrashKeyValue("commit_frame_id",
-                                  base::IntToString(GetRoutingID()));
-    base::debug::SetCrashKeyValue("commit_proxy_id",
-                                  base::IntToString(proxy_routing_id));
-    base::debug::SetCrashKeyValue(
-        "commit_view_id", base::IntToString(render_view_->GetRoutingID()));
-    if (render_view_->main_render_frame_) {
-      base::debug::SetCrashKeyValue(
-          "commit_main_render_frame_id",

[Charlie Reis, 2017/05/09 16:42:26]

I don't see any instances of this crash key value since M55.  Interestingly,
that's before we even moved this code from didCommitProvisionalLoad to SwapIn
(in M57), so the fact that we're seeing crashes on the !in_frame_tree_ line
above doesn't explain the difference.

https://crash.corp.google.com/browse?q=OMIT%20RECORD%20IF%20SOME(ProductData....

If it does recur, we can always add diagnostics again.

[alexmos, 2017/05/09 21:26:55]

Acknowledged.

-          base::IntToString(render_view_->main_render_frame_->GetRoutingID()));
-    }
     CHECK(!render_view_->main_render_frame_);
     render_view_->main_render_frame_ = this;
     if (render_view_->is_swapped_out())
       render_view_->SetSwappedOut(false);
   }
 
   return true;
 }
 
 void RenderFrameImpl::DidStartLoading(bool to_different_document) {
@@ skipping 1861 matching lines @@
       policy(info.default_policy),
       replaces_current_history_item(info.replaces_current_history_item),
       history_navigation_in_new_child_frame(
           info.is_history_navigation_in_new_child_frame),
       client_redirect(info.is_client_redirect),
       cache_disabled(info.is_cache_disabled),
       form(info.form),
       source_location(info.source_location) {}
 
 }  // namespace content