PRESUBMIT.py - Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting (Closed)

Patch Set: Function works. Needs to refactor blimp_url_rewriter_unittest.cc Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 2677a4e487a095e178c57578a0ab1417112c8b15..38786cf2b99db614d909eb7de907dfc979415c22 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -188,6 +188,8 @@ _BANNED_CPP_FUNCTIONS = (

r"^base[\\\/]process[\\\/]process_linux\.cc$",

r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",

r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$",

+ r"^blimp[\\\/]engine[\\\/]testing[\\\/]app[\\\/]" +

+ r"blimp_browser_testing_main_parts\.cc$",

r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",

r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",

r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"

« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | blimp/engine/DEPS » ('J')