Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: blimp/engine/testing/app/blimp_content_main_delegate_for_test.cc

Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting (Closed)
Patch Set: John comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <memory>
6
7 #include "blimp/engine/testing/app/blimp_content_browser_client_for_test.h"
Kevin M 2017/01/09 20:17:17 Missing include on base/ptr_util.h ?
shenghuazhang 2017/01/10 23:20:49 Done.
8 #include "blimp/engine/testing/app/blimp_content_main_delegate_for_test.h"
Kevin M 2017/01/09 20:17:17 The include that corresponds to this CC should be
shenghuazhang 2017/01/10 23:20:49 Done.
9 #include "blimp/engine/testing/app/blimp_url_rewriter.h"
Kevin M 2017/01/09 20:17:17 Not used?
shenghuazhang 2017/01/10 23:20:49 Done.
10
11 namespace blimp {
12 namespace engine {
13
14 BlimpContentMainDelegateForTest::BlimpContentMainDelegateForTest() {}
15
16 content::ContentBrowserClient*
17 BlimpContentMainDelegateForTest::CreateContentBrowserClient() {
18 std::unique_ptr<BlimpContentBrowserClient> browser_client_for_test =
19 base::MakeUnique<BlimpContentBrowserClientForTest>();
20 content::ContentBrowserClient* client_ptr = browser_client_for_test.get();
21 BlimpContentMainDelegate::SetContentBrowserClientForTesting(
Kevin M 2017/01/09 20:17:17 Remove "BlimpContentMainDelegate"?
shenghuazhang 2017/01/10 23:20:49 Done.
22 std::move(browser_client_for_test));
23 return client_ptr;
24 }
25
26 } // namespace engine
27 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698