blimp/engine/DEPS - Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/engine/DEPS

Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting (Closed)

Patch Set: Function works. Needs to refactor blimp_url_rewriter_unittest.cc Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+base",	2 "+base",

3 "-blimp/client",	3 "-blimp/client",

4 "+cc",	4 "+cc",

5 "-chrome",	5 "-chrome",

6 "+components/crash",	6 "+components/crash",

7 "+components/metrics",	7 "+components/metrics",

8 "+components/pref_registry",	8 "+components/pref_registry",

9 "+components/prefs",	9 "+components/prefs",

10 "+components/version_info",	10 "+components/version_info",

11 "+components/web_cache/renderer",	11 "+components/web_cache/renderer",

	12 "+content/browser",
	jbudorick at gmail 2017/01/06 16:09:36 I think depending on the nonpublic part of content I think depending on the nonpublic part of content/ is frowned upon. shenghuazhang 2017/01/07 01:21:24 Replace the #include "content/browser/browser_url_ Show quoted text On 2017/01/06 16:09:36, jbudorick at gmail wrote: > I think depending on the nonpublic part of content/ is frowned upon. Replace the #include "content/browser/browser_url_handler_impl.h" by "content/public/browser/browser_url_handler.h" in blimp_url_rewriter_unittest.cc and it wouldn't complain excluding this rule. Will remove it in the next patch.
12 "+content/public",	13 "+content/public",

13 "+device/geolocation",	14 "+device/geolocation",

14 "+mojo/public",	15 "+mojo/public",

15 "+net",	16 "+net",

16 "+services/service_manager/public/cpp",	17 "+services/service_manager/public/cpp",

17 "+third_party/blimp_fonts",	18 "+third_party/blimp_fonts",

18 "+third_party/khronos/GLES2/gl2.h",	19 "+third_party/khronos/GLES2/gl2.h",

19 "+third_party/WebKit/public/platform/WebGestureEvent.h",	20 "+third_party/WebKit/public/platform/WebGestureEvent.h",

20 "+third_party/WebKit/public/platform/WebInputEvent.h",	21 "+third_party/WebKit/public/platform/WebInputEvent.h",

21 "+ui/aura",	22 "+ui/aura",

22 "+ui/base",	23 "+ui/base",

23 "+ui/compositor",	24 "+ui/compositor",

24 "+ui/display",	25 "+ui/display",

25 "+ui/events",	26 "+ui/events",

26 "+ui/gfx",	27 "+ui/gfx",

27 "+ui/gl",	28 "+ui/gl",

28 "+ui/native_theme",	29 "+ui/native_theme",

29 "+ui/platform_window",	30 "+ui/platform_window",

30 "+ui/resources",	31 "+ui/resources",

31 "+ui/wm",	32 "+ui/wm",

32 ]	33 ]

OLD	NEW

« no previous file with comments | « blimp/engine/BUILD.gn ('k') | blimp/engine/app/blimp_browser_main_parts.h » ('j') | blimp/engine/app/blimp_content_browser_client.h » ('J')