Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: PRESUBMIT.py

Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting (Closed)
Patch Set: nit change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 'ScopedAllowIO', 181 'ScopedAllowIO',
182 ( 182 (
183 'New code should not use ScopedAllowIO. Post a task to the blocking', 183 'New code should not use ScopedAllowIO. Post a task to the blocking',
184 'pool or the FILE thread instead.', 184 'pool or the FILE thread instead.',
185 ), 185 ),
186 True, 186 True,
187 ( 187 (
188 r"^base[\\\/]process[\\\/]process_linux\.cc$", 188 r"^base[\\\/]process[\\\/]process_linux\.cc$",
189 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 189 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
190 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$", 190 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$",
191 r"^blimp[\\\/]engine[\\\/]testing[\\\/]app[\\\/]" +
192 r"test_blimp_browser_main_parts\.cc$",
191 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", 193 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
192 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", 194 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
193 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" 195 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
194 "customization_document_browsertest\.cc$", 196 "customization_document_browsertest\.cc$",
195 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 197 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
196 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + 198 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +
197 r"test_info_extractor\.cc$", 199 r"test_info_extractor\.cc$",
198 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", 200 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$",
199 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 201 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
200 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 202 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
(...skipping 2142 matching lines...) Expand 10 before | Expand all | Expand 10 after
2343 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2345 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2344 input_api, 2346 input_api,
2345 output_api, 2347 output_api,
2346 json_url='http://chromium-status.appspot.com/current?format=json')) 2348 json_url='http://chromium-status.appspot.com/current?format=json'))
2347 2349
2348 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2350 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2349 input_api, output_api)) 2351 input_api, output_api))
2350 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2352 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2351 input_api, output_api)) 2353 input_api, output_api))
2352 return results 2354 return results
OLDNEW
« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698