Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: PRESUBMIT.py

Issue 2572563006: [Blimp] Refactor Blimp test engine with embedded test server and URL rewriting (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 'ScopedAllowIO', 189 'ScopedAllowIO',
190 ( 190 (
191 'New code should not use ScopedAllowIO. Post a task to the blocking', 191 'New code should not use ScopedAllowIO. Post a task to the blocking',
192 'pool or the FILE thread instead.', 192 'pool or the FILE thread instead.',
193 ), 193 ),
194 True, 194 True,
195 ( 195 (
196 r"^base[\\\/]process[\\\/]process_linux\.cc$", 196 r"^base[\\\/]process[\\\/]process_linux\.cc$",
197 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", 197 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$",
198 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$", 198 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$",
199 r"^blimp[\\\/]engine[\\\/]testing[\\\/]app[\\\/]" +
200 r"blimp_browser_testing_main_parts\.cc$",
199 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", 201 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
200 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$", 202 r"^chrome[\\\/]browser[\\\/]lifetime[\\\/]application_lifetime\.cc$",
201 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" 203 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
202 "customization_document_browsertest\.cc$", 204 "customization_document_browsertest\.cc$",
203 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 205 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
204 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" + 206 r"^content[\\\/]shell[\\\/]browser[\\\/]layout_test[\\\/]" +
205 r"test_info_extractor\.cc$", 207 r"test_info_extractor\.cc$",
206 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$", 208 r"^content[\\\/].*browser(|_)test[a-zA-Z_]*\.cc$",
207 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 209 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
208 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 210 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
(...skipping 2138 matching lines...) Expand 10 before | Expand all | Expand 10 after
2347 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2349 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2348 input_api, 2350 input_api,
2349 output_api, 2351 output_api,
2350 json_url='http://chromium-status.appspot.com/current?format=json')) 2352 json_url='http://chromium-status.appspot.com/current?format=json'))
2351 2353
2352 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2354 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2353 input_api, output_api)) 2355 input_api, output_api))
2354 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2356 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2355 input_api, output_api)) 2357 input_api, output_api))
2356 return results 2358 return results
OLDNEW
« no previous file with comments | « no previous file | blimp/engine/BUILD.gn » ('j') | blimp/engine/testing/app/blimp_browser_testing_main_parts.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698