Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 257253003: Revert of add more polymer tests (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
Reviewers:
ykyyip, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org, awong
Visibility:
Public.

Description

Revert of add more polymer tests (https://codereview.chromium.org/257283002/) Reason for revert: This delta breaks telemetry_perf_unittests testMeasurementSmoke ERROR:root:Errored pages: http://localhost:8000/components/paper-calculator/demo.html Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper func(*args, **kwargs) File "/mnt/data/b/build/slave/Linux_ChromiumOS_Tests__1_/build/src/tools/perf/measurements/measurement_unittest.py", line 73, in testMeasurementSmoke msg='Failed: %s' % benchmark) AssertionError: Failed: <class 'benchmarks.thread_times.ThreadTimesPolymer'> Original issue's description: > add more polymer tests > > BUG=333078 > R=dtu@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266955 TBR=dtu@chromium.org,ykyyip@chromium.org NOTREECHECKS=true NOTRY=true BUG=333078 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 chunk +1 line, -36 lines 0 comments Download
M tools/perf/benchmarks/thread_times.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robliao
Created Revert of add more polymer tests
6 years, 7 months ago (2014-04-29 21:56:03 UTC) #1
robliao
6 years, 7 months ago (2014-04-29 21:56:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/257253003/1
6 years, 7 months ago (2014-04-29 21:57:51 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 22:02:29 UTC) #4
Message was sent while issue was closed.
Change committed as 266971

Powered by Google App Engine
This is Rietveld 408576698