chrome/browser/ui/tab_helpers.cc - Issue 2572433002: Disable tracking of visits to bookmarks in incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2572433002: Disable tracking of visits to bookmarks in incognito (Closed)

Patch Set: Bernhard's comments #2 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 0620678938651c6061e1ea477145619afbe9b99f..74e762cf20c2e4276b868ce290ef36326b2ee490 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -158,7 +158,7 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

autofill::ChromeAutofillClient::FromWebContents(web_contents),

g_browser_process->GetApplicationLocale(),

autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);

- BookmarkLastVisitUpdater::CreateForWebContentsWithBookmarkModel(

+ BookmarkLastVisitUpdater::MaybeCreateForWebContentsWithBookmarkModel(

web_contents, BookmarkModelFactory::GetForBrowserContext(

web_contents->GetBrowserContext()));

chrome_browser_net::NetErrorTabHelper::CreateForWebContents(web_contents);