Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/net/third_party/nss/ssl/BUILD.gn

Issue 257243003: Revert 266932 "GN build improvements." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/components/translate/BUILD.gn ('k') | trunk/src/third_party/expat/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/third_party/nss/ssl/BUILD.gn
===================================================================
--- trunk/src/net/third_party/nss/ssl/BUILD.gn (revision 266932)
+++ trunk/src/net/third_party/nss/ssl/BUILD.gn (working copy)
@@ -118,8 +118,8 @@
forward_dependent_configs_from = deps
}
- if (!is_win && component_mode == "shared_library") {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+ if (component_mode == "shared_library") {
+ # TODO(brettw) GCC_SYMBOLS_PRIVATE_EXTERN thing.
}
if (is_clang) {
« no previous file with comments | « trunk/src/components/translate/BUILD.gn ('k') | trunk/src/third_party/expat/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698