Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 2572423004: Reapply "Save and restore feedback from JIT." (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 6d103b889c9a06c294e65bf0bc2150e6bc9a12b1..a3db43828ea03045a462dc7a4116889524d1d712 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -67,14 +67,6 @@ DECLARE_FLAG(int, reoptimization_counter_threshold);
DECLARE_FLAG(int, stacktrace_every);
DECLARE_FLAG(charp, stacktrace_filter);
DECLARE_FLAG(bool, trace_compiler);
-DECLARE_FLAG(int, inlining_hotness);
-DECLARE_FLAG(int, inlining_size_threshold);
-DECLARE_FLAG(int, inlining_callee_size_threshold);
-DECLARE_FLAG(int, inline_getters_setters_smaller_than);
-DECLARE_FLAG(int, inlining_depth_threshold);
-DECLARE_FLAG(int, inlining_caller_size_threshold);
-DECLARE_FLAG(int, inlining_constant_arguments_max_size_threshold);
-DECLARE_FLAG(int, inlining_constant_arguments_min_size_threshold);
DECLARE_FLAG(int, reload_every);
DECLARE_FLAG(bool, unbox_numeric_fields);
@@ -84,22 +76,6 @@ static void PrecompilationModeHandler(bool value) {
FATAL("Precompilation not supported on IA32");
#endif
-#if !defined(DART_PRECOMPILED_RUNTIME)
- // Flags affecting compilation only:
- // There is no counter feedback in precompilation, so ignore the counter
- // when making inlining decisions.
- FLAG_inlining_hotness = 0;
- // Use smaller thresholds in precompilation as we are compiling everything
- // with the optimizing compiler instead of only hot functions.
- FLAG_inlining_size_threshold = 5;
- FLAG_inline_getters_setters_smaller_than = 5;
- FLAG_inlining_callee_size_threshold = 20;
- FLAG_inlining_depth_threshold = 4;
- FLAG_inlining_caller_size_threshold = 1000;
- FLAG_inlining_constant_arguments_max_size_threshold = 100;
- FLAG_inlining_constant_arguments_min_size_threshold = 30;
-#endif
-
FLAG_background_compilation = false;
FLAG_fields_may_be_reset = true;
FLAG_interpret_irregexp = true;

Powered by Google App Engine
This is Rietveld 408576698