Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2572423004: Reapply "Save and restore feedback from JIT." (Closed)

Created:
4 years ago by rmacnak
Modified:
4 years ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Save and restore feedback from JIT." Ensure ICData is attached to the callee flow graph in the inliner when built from kernel IR, not just from source. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/4607e38d2864b8f54c59ff2ab6cdaf403fc3f043

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1695 lines, -569 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 7 chunks +66 lines, -3 lines 0 comments Download
M runtime/include/dart_api.h View 2 chunks +20 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/aot_optimizer.cc View 2 chunks +45 lines, -67 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 9 chunks +175 lines, -41 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 14 chunks +46 lines, -10 lines 1 comment Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/vm/json_parser.h View 1 chunk +331 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 11 chunks +263 lines, -263 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +65 lines, -25 lines 0 comments Download
M runtime/vm/precompiler.h View 7 chunks +97 lines, -33 lines 0 comments Download
M runtime/vm/precompiler.cc View 18 chunks +437 lines, -87 lines 0 comments Download
A runtime/vm/program_visitor.h View 1 chunk +33 lines, -0 lines 0 comments Download
A runtime/vm/program_visitor.cc View 1 chunk +95 lines, -0 lines 0 comments Download
M runtime/vm/thread.h View 3 chunks +0 lines, -7 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/version.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/version_in.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
https://codereview.chromium.org/2572423004/diff/1/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/2572423004/diff/1/runtime/vm/flow_graph_inliner.cc#newcode810 runtime/vm/flow_graph_inliner.cc:810: if (FLAG_precompiled_mode) { The change was to move this ...
4 years ago (2016-12-16 22:22:05 UTC) #2
Florian Schneider
lgtm
4 years ago (2016-12-16 22:23:33 UTC) #3
rmacnak
4 years ago (2016-12-17 00:00:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4607e38d2864b8f54c59ff2ab6cdaf403fc3f043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698