Add preliminary packages file support to dependency_grapher.

Add preliminary packages file support to dependency_grapher.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/519f7d402505114e4248f8e23879e2b3b92e5d0b

[Paul Berry, 2016-12-16 03:18:27]

paulberry@google.com changed reviewers:
+ danrubel@google.com, sigmund@google.com

[Siggi Cherem (dart-lang), 2016-12-16 16:30:39]

lgtm

https://codereview.chromium.org/2572383004/diff/1/pkg/front_end/lib/dependenc...
File pkg/front_end/lib/dependency_grapher.dart (right):

https://codereview.chromium.org/2572383004/diff/1/pkg/front_end/lib/dependenc...
pkg/front_end/lib/dependency_grapher.dart:28: throw new UnimplementedError(); //
TODO(paulberry): search for .packages
mmm... I recognize the value of having an abstraction for the file system in
front-end, but I hope we can avoid duplicating the discovery algorithms for
this.

Some ideas:
 - move package-config to frontend (I personally like keeping it separate
though)
 - limit when we support some features, for example, package-discovery is only
supported when using the IO file system

[Paul Berry, 2016-12-16 17:59:07]

https://codereview.chromium.org/2572383004/diff/1/pkg/front_end/lib/dependenc...
File pkg/front_end/lib/dependency_grapher.dart (right):

https://codereview.chromium.org/2572383004/diff/1/pkg/front_end/lib/dependenc...
pkg/front_end/lib/dependency_grapher.dart:28: throw new UnimplementedError(); //
TODO(paulberry): search for .packages
On 2016/12/16 16:30:38, Siggi Cherem (dart-lang) wrote:
> mmm... I recognize the value of having an abstraction for the file system in
> front-end, but I hope we can avoid duplicating the discovery algorithms for
> this.
> 
> Some ideas:
>  - move package-config to frontend (I personally like keeping it separate
> though)
>  - limit when we support some features, for example, package-discovery is only
> supported when using the IO file system

Acknowledged.

[Paul Berry, 2016-12-16 18:07:34]

Description was changed from

==========
Add preliminary packages file support to dependency_grapher.
==========

to

==========
Add preliminary packages file support to dependency_grapher.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/519f7d402505114e4248f8e23879e2b3b92e5d0b
==========

[Paul Berry, 2016-12-16 18:07:35]

Committed patchset #1 (id:1) manually as
519f7d402505114e4248f8e23879e2b3b92e5d0b (presubmit successful).