third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp - Issue 2572323002: Delete WebGamepads::length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

Issue 2572323002: Delete WebGamepads::length. (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

diff --git a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

index 8b4411abfaefc37c1c2b2bd3ea5224e79e06a36b..1dd81ed9d38c11f6266dd88a574a475fecccc33c 100644

--- a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

+++ b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp

@@ -59,7 +59,7 @@ static void sampleGamepads(ListType* into) {

for (unsigned i = 0; i < WebGamepads::itemsLengthCap; ++i) {

WebGamepad& webGamepad = gamepads.items[i];

- if (i < gamepads.length && webGamepad.connected) {

+ if (webGamepad.connected) {

GamepadType* gamepad = into->item(i);

if (!gamepad)

gamepad = GamepadType::create();