Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc

Issue 2572323002: Delete WebGamepads::length. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/gamepad_controller.cc ('k') | device/gamepad/gamepad_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
diff --git a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
index 4075847c58fa29bcc2f36c75f78de3c2296291b4..cb42e44c2f9fb688023d3996188054da4dc69824 100644
--- a/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
+++ b/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
@@ -76,8 +76,6 @@ TEST_F(PepperGamepadHostTest, ValidateGamepadsMatch) {
"gamepads data must match");
ppapi::WebKitGamepads ppapi_gamepads;
blink::WebGamepads web_gamepads;
- EXPECT_EQ(AddressDiff(&web_gamepads.length, &web_gamepads),
- AddressDiff(&ppapi_gamepads.length, &ppapi_gamepads));
// See comment below on storage & the EXPECT macro.
size_t webkit_items_length_cap = blink::WebGamepads::itemsLengthCap;
@@ -137,7 +135,6 @@ TEST_F(PepperGamepadHostTest, ValidateGamepadMatch) {
TEST_F(PepperGamepadHostTest, MAYBE_WaitForReply) {
blink::WebGamepads default_data;
memset(&default_data, 0, sizeof(blink::WebGamepads));
- default_data.length = 1;
default_data.items[0].connected = true;
default_data.items[0].buttonsLength = 1;
ConstructService(default_data);
@@ -185,7 +182,6 @@ TEST_F(PepperGamepadHostTest, MAYBE_WaitForReply) {
const ppapi::ContentGamepadHardwareBuffer* buffer =
static_cast<const ppapi::ContentGamepadHardwareBuffer*>(
shared_memory.memory());
- EXPECT_EQ(button_down_data.length, buffer->buffer.length);
EXPECT_EQ(button_down_data.items[0].buttonsLength,
buffer->buffer.items[0].buttons_length);
for (size_t i = 0; i < ppapi::WebKitGamepad::kButtonsLengthCap; i++) {
« no previous file with comments | « components/test_runner/gamepad_controller.cc ('k') | device/gamepad/gamepad_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698