Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2572253002: DO NOT SUBMIT shrink R.java files via inheritance (Closed)

Created:
4 years ago by F
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT SUBMIT shrink R.java files via inheritance Explores the idea of reducing code size by using inheritance on R.java files. See attached bug link for discussion and results. BUG=671648

Patch Set 1 #

Patch Set 2 : not using org.chromium package prefix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -8 lines) Patch
M build/android/gyp/process_resources.py View 1 8 chunks +54 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
F
4 years ago (2016-12-14 21:46:47 UTC) #1 
Description was changed from

==========
DO NOT SUBMIT shrink R.java files via inheritance

Explores the idea of reducing code size by using inheritance on R.java files.
See attached bug link for discussion and results.

BUG=671648
==========

to

==========
DO NOT SUBMIT shrink R.java files via inheritance

Explores the idea of reducing code size by using inheritance on R.java
files. See attached bug link for discussion and results.

BUG=671648
==========

Powered by Google App Engine
This is Rietveld 408576698