Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart

Issue 2572203002: Add completion tests for the new analysis driver. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
index 7d3acd892c7529d4a8ec9e11ef1a3e1947e4b7c5..110f60dd6a3708f8045d64b31ded24317586aa85 100644
--- a/pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
@@ -21,6 +21,7 @@ import 'completion_contributor_util.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(ImportedReferenceContributorTest);
+ defineReflectiveTests(ImportedReferenceContributorTest_Driver);
});
}
@@ -34,17 +35,6 @@ class ImportedReferenceContributorTest extends DartCompletionContributorTest {
return new ImportedReferenceContributor();
}
- fail_enum_deprecated() async {
- addSource('/libA.dart', 'library A; @deprecated enum E { one, two }');
- addTestSource('import "/libA.dart"; main() {^}');
- await computeSuggestions();
- // TODO(danrube) investigate why suggestion/element is not deprecated
- // when AST node has correct @deprecated annotation
- assertSuggestEnum('E', isDeprecated: true);
- assertNotSuggested('one');
- assertNotSuggested('two');
- }
-
test_ArgumentList() async {
// ArgumentList MethodInvocation ExpressionStatement Block
resolveSource(
@@ -1968,6 +1958,18 @@ int myFunc() {}
assertNotSuggested('two');
}
+ @failingTest
+ test_enum_deprecated() async {
+ addSource('/libA.dart', 'library A; @deprecated enum E { one, two }');
+ addTestSource('import "/libA.dart"; main() {^}');
+ await computeSuggestions();
+ // TODO(danrube) investigate why suggestion/element is not deprecated
+ // when AST node has correct @deprecated annotation
+ assertSuggestEnum('E', isDeprecated: true);
+ assertNotSuggested('one');
+ assertNotSuggested('two');
+ }
+
test_ExpressionStatement_identifier() async {
// SimpleIdentifier ExpressionStatement Block
resolveSource(
@@ -4509,3 +4511,302 @@ class B extends A {
assertNotSuggested('e');
}
}
+
+@reflectiveTest
+class ImportedReferenceContributorTest_Driver
+ extends ImportedReferenceContributorTest {
+ @override
+ bool get enableNewAnalysisDriver => true;
+
+ @failingTest
+ @override
+ test_ArgumentList() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ArgumentList();
+ }
+
+ @failingTest
+ @override
+ test_ArgumentList_imported_function() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ArgumentList_imported_function();
+ }
+
+ @failingTest
+ @override
+ test_ArgumentList_local_function() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ArgumentList_local_function();
+ }
+
+ @failingTest
+ @override
+ test_ArgumentList_local_method() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ArgumentList_local_method();
+ }
+
+ @failingTest
+ @override
+ test_AwaitExpression_function() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_AwaitExpression_function();
+ }
+
+ @failingTest
+ @override
+ test_Block_identifier_partial() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_Block_identifier_partial();
+ }
+
+ @failingTest
+ @override
+ test_ConditionalExpression_elseExpression_empty() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ConditionalExpression_elseExpression_empty();
+ }
+
+ @failingTest
+ @override
+ test_ConditionalExpression_partial_thenExpression_empty() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ConditionalExpression_partial_thenExpression_empty();
+ }
+
+ @failingTest
+ @override
+ test_doc_function() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_doc_function();
+ }
+
+ @failingTest
+ @override
+ test_doc_function_c_style() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_doc_function_c_style();
+ }
+
+ @override
+ test_enum_deprecated() {
+ // TODO(scheglov) remove it?
+ }
+
+ @failingTest
+ @override
+ test_ExpressionStatement_identifier() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_ExpressionStatement_identifier();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_mixed_required_and_named() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_mixed_required_and_named();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_mixed_required_and_positional() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_mixed_required_and_positional();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_named() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_named();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_none() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_none();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_positional() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_positional();
+ }
+
+ @failingTest
+ @override
+ test_function_parameters_required() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_function_parameters_required();
+ }
+
+ @failingTest
+ @override
+ test_FunctionDeclaration_returnType_afterComment() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_FunctionDeclaration_returnType_afterComment();
+ }
+
+ @failingTest
+ @override
+ test_FunctionDeclaration_returnType_afterComment2() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_FunctionDeclaration_returnType_afterComment2();
+ }
+
+ @failingTest
+ @override
+ test_FunctionDeclaration_returnType_afterComment3() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_FunctionDeclaration_returnType_afterComment3();
+ }
+
+ @failingTest
+ @override
+ test_IndexExpression() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_IndexExpression();
+ }
+
+ @failingTest
+ @override
+ test_InstanceCreationExpression() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_InstanceCreationExpression();
+ }
+
+ @failingTest
+ @override
+ test_keyword() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_keyword();
+ }
+
+ @failingTest
+ @override
+ test_MapLiteralEntry2() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_MapLiteralEntry2();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_mixed_required_and_named() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_mixed_required_and_named();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_mixed_required_and_positional() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_mixed_required_and_positional();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_named() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_named();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_none() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_none();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_positional() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_positional();
+ }
+
+ @failingTest
+ @override
+ test_method_parameters_required() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_method_parameters_required();
+ }
+
+ @failingTest
+ @override
+ test_MethodDeclaration_returnType() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_MethodDeclaration_returnType();
+ }
+
+ @failingTest
+ @override
+ test_MethodDeclaration_returnType_afterComment() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_MethodDeclaration_returnType_afterComment();
+ }
+
+ @failingTest
+ @override
+ test_MethodDeclaration_returnType_afterComment2() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_MethodDeclaration_returnType_afterComment2();
+ }
+
+ @failingTest
+ @override
+ test_MethodDeclaration_returnType_afterComment3() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_MethodDeclaration_returnType_afterComment3();
+ }
+
+ @failingTest
+ @override
+ test_no_parameters_getter() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_no_parameters_getter();
+ }
+
+ @failingTest
+ @override
+ test_partFile_TypeName() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_partFile_TypeName();
+ }
+
+ @failingTest
+ @override
+ test_partFile_TypeName2() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_partFile_TypeName2();
+ }
+
+ @failingTest
+ @override
+ test_TypeArgumentList() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_TypeArgumentList();
+ }
+
+ @failingTest
+ @override
+ test_doc_class() {
+// Expected: 'My class.\n'
+// 'Short description.'
+// Actual: 'My class./// Short description.////// Longer description.'
+// Which: is different.
+// Expected: My class.\nShort de ...
+// Actual: My class./// Short ...
+// ^
+// Differ at offset 9
+ return super.test_doc_class();
+ }
+
+ @failingTest
+ @override
+ test_VariableDeclarationStatement_RHS_missing_semicolon() {
+ // Bad state: Should not be used with the new analysis driver.
+ return super.test_VariableDeclarationStatement_RHS_missing_semicolon();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698