Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 25722007: Corrected UA style for a:focus in simpleUserAgentStyleSheet. (Closed)

Created:
7 years, 2 months ago by rune
Modified:
7 years, 2 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Corrected UA style for a:focus in simpleUserAgentStyleSheet. simpleUserAgentStyleSheet did not have an outline on a:focus like html.css. The result was flakiness for the following test depending on whether the full UA styles had been triggered by a previous test or not: LayoutTests/fast/events/reveal-link-when-focused.html R=ojan@chromium.org BUG=303323 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
7 years, 2 months ago (2013-10-02 22:47:25 UTC) #1
ojan
lgtm
7 years, 2 months ago (2013-10-02 23:07:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25722007/1
7 years, 2 months ago (2013-10-02 23:07:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=6503
7 years, 2 months ago (2013-10-03 00:23:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25722007/1
7 years, 2 months ago (2013-10-03 08:36:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=8522
7 years, 2 months ago (2013-10-03 12:50:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/25722007/1
7 years, 2 months ago (2013-10-03 13:14:04 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 14:17:45 UTC) #8
Message was sent while issue was closed.
Change committed as 158814

Powered by Google App Engine
This is Rietveld 408576698