Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc

Issue 2572133002: Add more features to ntp-tiles-internal (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
diff --git a/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc b/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
index 554f34b8351cc4443000736dddd78368191b7b53..99c96ae0df721dbca44b6249cbbfdb7bddce5de1 100644
--- a/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
+++ b/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
@@ -7,7 +7,6 @@
#include "components/grit/components_resources.h"
#include "components/ntp_tiles/field_trial.h"
#include "components/ntp_tiles/most_visited_sites.h"
-#include "components/ntp_tiles/popular_sites.h"
#include "components/ntp_tiles/webui/ntp_tiles_internals_message_handler.h"
#include "components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
@@ -33,9 +32,8 @@ class IOSNTPTilesInternalsMessageHandlerBridge
void RegisterMessages() override;
// ntp_tiles::NTPTilesInternalsMessageHandlerClient
- bool DoesSourceExist(ntp_tiles::NTPTileSource source) override;
+ base::SequencedWorkerPool* GetBlockingPool() override;
std::unique_ptr<ntp_tiles::MostVisitedSites> MakeMostVisitedSites() override;
- std::unique_ptr<ntp_tiles::PopularSites> MakePopularSites() override;
PrefService* GetPrefs() override;
void RegisterMessageCallback(
const std::string& message,
@@ -53,18 +51,9 @@ void IOSNTPTilesInternalsMessageHandlerBridge::RegisterMessages() {
handler_.RegisterMessages(this);
}
-bool IOSNTPTilesInternalsMessageHandlerBridge::DoesSourceExist(
- ntp_tiles::NTPTileSource source) {
- switch (source) {
- case ntp_tiles::NTPTileSource::TOP_SITES:
- case ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE:
- case ntp_tiles::NTPTileSource::POPULAR:
- return true;
- case ntp_tiles::NTPTileSource::WHITELIST:
- return false;
- }
- NOTREACHED();
- return false;
+base::SequencedWorkerPool*
+IOSNTPTilesInternalsMessageHandlerClient::GetBlockingPool() {
+ return web::WebThread::GetBlockingPool();
}
std::unique_ptr<ntp_tiles::MostVisitedSites>
@@ -73,12 +62,6 @@ IOSNTPTilesInternalsMessageHandlerBridge::MakeMostVisitedSites() {
ios::ChromeBrowserState::FromWebUIIOS(web_ui()));
}
-std::unique_ptr<ntp_tiles::PopularSites>
-IOSNTPTilesInternalsMessageHandlerBridge::MakePopularSites() {
- return IOSPopularSitesFactory::NewForBrowserState(
- ios::ChromeBrowserState::FromWebUIIOS(web_ui()));
-}
-
PrefService* IOSNTPTilesInternalsMessageHandlerBridge::GetPrefs() {
return ios::ChromeBrowserState::FromWebUIIOS(web_ui())->GetPrefs();
}
@@ -95,8 +78,6 @@ void IOSNTPTilesInternalsMessageHandlerBridge::CallJavascriptFunctionVector(
web_ui()->CallJavascriptFunction(name, values);
}
-} // namespace
-
web::WebUIIOSDataSource* CreateNTPTilesInternalsHTMLSource() {
web::WebUIIOSDataSource* source =
web::WebUIIOSDataSource::Create(kChromeUINTPTilesInternalsHost);
@@ -108,6 +89,8 @@ web::WebUIIOSDataSource* CreateNTPTilesInternalsHTMLSource() {
return source;
}
+} // namespace
+
NTPTilesInternalsUI::NTPTilesInternalsUI(web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) {
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui),

Powered by Google App Engine
This is Rietveld 408576698