DevTools: kill SDK.CSSParser

third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 19 matching lines @@
  * @unrestricted
  */
 Sources.StyleSheetOutlineDialog = class extends UI.FilteredListWidget.Delegate {
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {function(number, number)} selectItemCallback
    */
   constructor(uiSourceCode, selectItemCallback) {
     super([]);
     this._selectItemCallback = selectItemCallback;
-    this._cssParser = new SDK.CSSParser();
-    this._cssParser.addEventListener(SDK.CSSParser.Events.RulesParsed, this.refresh.bind(this));
-    this._cssParser.parse(uiSourceCode.workingCopy());
+    this._rules = [];

[dgozman, 2016/12/14 19:05:02]

Let's @type this for compiler to kick-in.

[lushnikov, 2016/12/15 00:28:46]

Done.

+    Common.formatterWorkerPool.parseCSS(uiSourceCode.workingCopy(), (isLastChunk, rules) => {
+      this._rules.push(...rules);

[dgozman, 2016/12/14 19:05:02]

Are you sure this is safe to do?

[lushnikov, 2016/12/15 00:28:46]

The feature has hit stable and looks simple. Should be fine! 

+      this.refresh();
+    });
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {function(number, number)} selectItemCallback
    */
   static show(uiSourceCode, selectItemCallback) {
     Sources.StyleSheetOutlineDialog._instanceForTests =
         new Sources.StyleSheetOutlineDialog(uiSourceCode, selectItemCallback);
     new UI.FilteredListWidget(Sources.StyleSheetOutlineDialog._instanceForTests).showAsDialog();
   }
 
   /**
    * @override
    * @return {number}
    */
   itemCount() {
-    return this._cssParser.rules().length;
+    return this._rules.length;
   }
 
   /**
    * @override
    * @param {number} itemIndex
    * @return {string}
    */
   itemKeyAt(itemIndex) {
-    var rule = this._cssParser.rules()[itemIndex];
+    var rule = this._rules[itemIndex];
     return rule.selectorText || rule.atRule;
   }
 
   /**
    * @override
    * @param {number} itemIndex
    * @param {string} query
    * @return {number}
    */
   itemScoreAt(itemIndex, query) {
-    var rule = this._cssParser.rules()[itemIndex];
+    var rule = this._rules[itemIndex];
     return -rule.lineNumber;
   }
 
   /**
    * @override
    * @param {number} itemIndex
    * @param {string} query
    * @param {!Element} titleElement
    * @param {!Element} subtitleElement
    */
   renderItem(itemIndex, query, titleElement, subtitleElement) {
-    var rule = this._cssParser.rules()[itemIndex];
+    var rule = this._rules[itemIndex];
     titleElement.textContent = rule.selectorText || rule.atRule;
     this.highlightRanges(titleElement, query);
     subtitleElement.textContent = ':' + (rule.lineNumber + 1);
   }
 
   /**
    * @override
    * @param {number} itemIndex
    * @param {string} promptValue
    */
   selectItem(itemIndex, promptValue) {
-    var rule = this._cssParser.rules()[itemIndex];
+    var rule = this._rules[itemIndex];
     var lineNumber = rule.lineNumber;
     if (!isNaN(lineNumber) && lineNumber >= 0)
       this._selectItemCallback(lineNumber, rule.columnNumber);
   }
-
-  /**
-   * @override
-   */
-  dispose() {
-    this._cssParser.dispose();
-  }
 };