ARM64: Use the shifter operand to merge in previous shift instructions.

src/arm64/lithium-arm64.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ARM64_LITHIUM_ARM64_H_
 #define V8_ARM64_LITHIUM_ARM64_H_
 
 #include "hydrogen.h"
 #include "lithium-allocator.h"
 #include "lithium.h"
@@ skipping 541 matching lines @@
   }
 
   LOperand* left() { return inputs_[0]; }
   LOperand* right() { return inputs_[1]; }
 
   DECLARE_CONCRETE_INSTRUCTION(AddE, "add-e")
   DECLARE_HYDROGEN_ACCESSOR(Add)
 };
 
 
-class LAddI V8_FINAL : public LTemplateInstruction<1, 2, 0> {
+class LShiftedRightOpInterface {
+ public:

[ulan, 2014/05/02 10:01:18]

Google style guide doesn't allow non-pure multiple inheritance.

One possible solution is to turn each function that accepts
LShiftedRightOpInterface* into a template with L-instructions as a template
parameter.

[Alexandre Rames, 2014/05/02 13:51:44]

Done.

+  LShiftedRightOpInterface()
+      : shift_(NO_SHIFT), shift_amount_(0) {}
+  LShiftedRightOpInterface(Shift shift, LOperand* shift_amount)
+      : shift_(shift), shift_amount_(shift_amount) {}
+
+  virtual ~LShiftedRightOpInterface() {}
+
+  Shift shift() const { return shift_; }
+  LOperand* shift_amount() const { return shift_amount_; }
+
+ protected:
+  Shift shift_;
+  LOperand* shift_amount_;
+};
+
+
+class LAddI V8_FINAL : public LTemplateInstruction<1, 2, 0>,
+                       public LShiftedRightOpInterface {
  public:
   LAddI(LOperand* left, LOperand* right) {
     inputs_[0] = left;
     inputs_[1] = right;
   }
+  LAddI(LOperand* left, LOperand* right, Shift shift, LOperand* shift_amount)
+      : LShiftedRightOpInterface(shift, shift_amount)  {
+    inputs_[0] = left;
+    inputs_[1] = right;
+  }
 
   LOperand* left() { return inputs_[0]; }
   LOperand* right() { return inputs_[1]; }
 
   DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i")
   DECLARE_HYDROGEN_ACCESSOR(Add)
 };
 
 
 class LAddS V8_FINAL : public LTemplateInstruction<1, 2, 0> {
@@ skipping 143 matching lines @@
   }
 
   LOperand* index() { return inputs_[0]; }
   LOperand* length() { return inputs_[1]; }
 
   DECLARE_CONCRETE_INSTRUCTION(BoundsCheck, "bounds-check")
   DECLARE_HYDROGEN_ACCESSOR(BoundsCheck)
 };
 
 
-class LBitI V8_FINAL : public LTemplateInstruction<1, 2, 0> {
+class LBitI V8_FINAL : public LTemplateInstruction<1, 2, 0>,
+                       public LShiftedRightOpInterface {
  public:
   LBitI(LOperand* left, LOperand* right) {
     inputs_[0] = left;
     inputs_[1] = right;
   }
 
+  LBitI(LOperand* left, LOperand* right, Shift shift, LOperand* shift_amount)
+      : LShiftedRightOpInterface(shift, shift_amount)  {
+    inputs_[0] = left;
+    inputs_[1] = right;
+  }
+
   LOperand* left() { return inputs_[0]; }
   LOperand* right() { return inputs_[1]; }
 
   Token::Value op() const { return hydrogen()->op(); }
 
   DECLARE_CONCRETE_INSTRUCTION(BitI, "bit-i")
   DECLARE_HYDROGEN_ACCESSOR(Bitwise)
 };
 
 
@@ skipping 1945 matching lines @@
 
   LOperand* value() { return inputs_[0]; }
   LOperand* temp1() { return temps_[0]; }
   LOperand* temp2() { return temps_[1]; }
 
   DECLARE_CONCRETE_INSTRUCTION(StoreGlobalCell, "store-global-cell")
   DECLARE_HYDROGEN_ACCESSOR(StoreGlobalCell)
 };
 
 
-class LSubI V8_FINAL : public LTemplateInstruction<1, 2, 0> {
+class LSubI V8_FINAL : public LTemplateInstruction<1, 2, 0>,
+                       public LShiftedRightOpInterface {
  public:
   LSubI(LOperand* left, LOperand* right) {
     inputs_[0] = left;
     inputs_[1] = right;
   }
 
+  LSubI(LOperand* left, LOperand* right, Shift shift, LOperand* shift_amount)
+      : LShiftedRightOpInterface(shift, shift_amount)  {
+    inputs_[0] = left;
+    inputs_[1] = right;
+  }
+
   LOperand* left() { return inputs_[0]; }
   LOperand* right() { return inputs_[1]; }
 
   DECLARE_CONCRETE_INSTRUCTION(SubI, "sub-i")
   DECLARE_HYDROGEN_ACCESSOR(Sub)
 };
 
 
 class LSubS: public LTemplateInstruction<1, 2, 0> {
  public:
@@ skipping 325 matching lines @@
       LInstruction* instr,
       HInstruction* hinstr,
       CanDeoptimize can_deoptimize = CANNOT_DEOPTIMIZE_EAGERLY);
 
   LInstruction* AssignPointerMap(LInstruction* instr);
   LInstruction* AssignEnvironment(LInstruction* instr);
 
   void VisitInstruction(HInstruction* current);
   void DoBasicBlock(HBasicBlock* block);
 
+  int ShiftAmountFromHConstant(HValue* constant) {
+    return HConstant::cast(constant)->Integer32Value() & 0x1f;
+  }
+  bool LikelyFitsImmField(HInstruction* instr, int imm) {
+    if (instr->IsAdd() || instr->IsSub()) {
+      return Assembler::IsImmAddSub(imm) || Assembler::IsImmAddSub(-imm);

[ulan, 2014/05/02 10:01:18]

Did you mean && instead of ||?

[Alexandre Rames, 2014/05/02 13:51:44]

'||' was intended. IsImmAddSub() works with unsigned values.

+    } else if (instr->IsBitwise()) {
+      unsigned unused_n, unused_imm_s, unused_imm_r;
+      return Assembler::IsImmLogical(imm, kWRegSizeInBits,
+                                     &unused_n, &unused_imm_s, &unused_imm_r);
+    } else {
+      UNREACHABLE();

[ulan, 2014/05/02 10:01:18]

nit: I'd slightly prefer a more compact ASSERT(instr->IsBitwise()) above without
this branch.

[Alexandre Rames, 2014/05/02 13:51:44]

Done.

+      return false;
+    }
+  }
+
+  // Indicates if a sequence of the form
+  //   lsl x8, x9, #imm
+  //   add x0, x1, x8
+  // can be replaced with:
+  //   add x0, x1, x9 LSL #imm
+  // If this is not possible, the function returns NULL. Otherwise it returns a
+  // pointer to the shift instruction that would be optimized away.
+  HBitwiseBinaryOperation* CanTransformToShiftedOp(HValue* val,
+                                                   HValue** left = NULL);
+  // Checks if all uses of the shift operation can optimize it away.
+  bool ShiftCanBeOptimizedAway(HBitwiseBinaryOperation* shift);
+  // Attempts to merge the binary operation and an eventual previous shift
+  // operation into a single operation. Returns the merged instruction on
+  // success, and NULL otherwise.
+  LInstruction* TryDoOpWithShiftedRightOperand(HBinaryOperation* op);
+  LInstruction* DoShiftedBinaryOp(HBinaryOperation* instr,
+                                  HValue* left,
+                                  HBitwiseBinaryOperation* shift);
+
   LInstruction* DoShift(Token::Value op, HBitwiseBinaryOperation* instr);
   LInstruction* DoArithmeticD(Token::Value op,
                               HArithmeticBinaryOperation* instr);
   LInstruction* DoArithmeticT(Token::Value op,
                               HBinaryOperation* instr);
 
   LPlatformChunk* chunk_;
   CompilationInfo* info_;
   HGraph* const graph_;
   Status status_;
   HInstruction* current_instruction_;
   HBasicBlock* current_block_;
   LAllocator* allocator_;
 
   DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
 };
 
 #undef DECLARE_HYDROGEN_ACCESSOR
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_ARM64_LITHIUM_ARM64_H_