third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl - Issue 2572003003: NOT FOR SUBMIT: use counters for jdm@

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

Issue 2572003003: NOT FOR SUBMIT: use counters for jdm@

Patch Set: Merge branch 'jdm-usecounters' into jdm-merge Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

index 36f21a7d3a235cd6e25c37eb1af839bc06cf41f1..bf05e0004617fa6b14bc0d29b4ec02a0951af293 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.idl

@@ -30,13 +30,13 @@

// https://w3c.github.io/ServiceWorker/#service-worker-container-interface

interface ServiceWorkerContainer : EventTarget {

- readonly attribute ServiceWorker? controller;

- [CallWith=ScriptState] readonly attribute Promise<ServiceWorkerRegistration> ready;

+ [Measure] readonly attribute ServiceWorker? controller;

+ [Measure, CallWith=ScriptState] readonly attribute Promise<ServiceWorkerRegistration> ready;

- [CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise<ServiceWorkerRegistration> register(USVString url, optional RegistrationOptions options);

- [CallWith=ScriptState] Promise<ServiceWorkerRegistration> getRegistration(optional USVString documentURL = "");

- [CallWith=ScriptState] Promise<sequence<ServiceWorkerRegistration>> getRegistrations();

+ [Measure, CallWith=ScriptState, ImplementedAs=registerServiceWorker] Promise<ServiceWorkerRegistration> register(USVString url, optional RegistrationOptions options);

+ [Measure, CallWith=ScriptState] Promise<ServiceWorkerRegistration> getRegistration(optional USVString documentURL = "");

+ [Measure, CallWith=ScriptState] Promise<sequence<ServiceWorkerRegistration>> getRegistrations();

- attribute EventHandler oncontrollerchange;

- attribute EventHandler onmessage;

+ [Measure] attribute EventHandler oncontrollerchange;

+ [Measure] attribute EventHandler onmessage;

};