third_party/WebKit/Source/core/editing/serializers/Serialization.cpp - Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2571953004: Migrate WTF::Vector::append() to ::push_back() [part 5 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

index c91ae7830da91c647ce182dcd493d0556cfedf9c..c5d16388a126b1dcce635e01da7be270af75d289 100644

--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

@@ -107,7 +107,7 @@ static void completeURLs(DocumentFragment& fragment, const String& baseURL) {

// AttributeCollection::iterator end = attributes.end();

for (const auto& attribute : attributes) {

if (element.isURLAttribute(attribute) && !attribute.value().isEmpty())

- changes.append(AttributeChange(

+ changes.push_back(AttributeChange(

&element, attribute.name(),

KURL(parsedBaseURL, attribute.value()).getString()));

}