Add sandbox_mac_unittests to the chromium.mac and chromium_trybot recipes.

Add sandbox_mac_unittests to the chromium.mac and chromium_trybot recipes.

BUG=367863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268279

[Paweł Hajdan Jr., 2014-04-29 15:26:31]

"not lgtm"

https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
File testing/buildbot/chromium.mac.json (right):

https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
testing/buildbot/chromium.mac.json:52: {"test": "sandbox_mac_unittests", "args":
["--single-process-tests"]},
Please *don't* use single-process-tests.

Why do you think it's needed? I'd be happy to help find a better solution.

[Robert Sesek, 2014-04-29 15:28:51]

https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
File testing/buildbot/chromium.mac.json (right):

https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
testing/buildbot/chromium.mac.json:52: {"test": "sandbox_mac_unittests", "args":
["--single-process-tests"]},
On 2014/04/29 15:26:31, Paweł Hajdan Jr. wrote:
> Please *don't* use single-process-tests.
> 
> Why do you think it's needed? I'd be happy to help find a better solution.

If you use MultiprocessTest, it takes about twice as long and prints this every
time:

[43313:1287:0429/101233:2761157347505818:WARNING:test_suite.cc(171)] Test
launcher output path
/var/folders/93/t6gtn1pn4vx9j4wjnzvkzz8m003bw_/T/.org.chromium.Chromium.r22Lp0/test_results.xml
exists. Not adding test launcher result printer.

[Robert Sesek, 2014-04-29 15:36:29]

On 2014/04/29 15:28:51, rsesek wrote:
>
https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
> File testing/buildbot/chromium.mac.json (right):
> 
>
https://codereview.chromium.org/257193002/diff/1/testing/buildbot/chromium.ma...
> testing/buildbot/chromium.mac.json:52: {"test": "sandbox_mac_unittests",
"args":
> ["--single-process-tests"]},
> On 2014/04/29 15:26:31, Paweł Hajdan Jr. wrote:
> > Please *don't* use single-process-tests.
> > 
> > Why do you think it's needed? I'd be happy to help find a better solution.
> 
> If you use MultiprocessTest, it takes about twice as long and prints this
every
> time:
> 
> [43313:1287:0429/101233:2761157347505818:WARNING:test_suite.cc(171)] Test
> launcher output path
>
/var/folders/93/t6gtn1pn4vx9j4wjnzvkzz8m003bw_/T/.org.chromium.Chromium.r22Lp0/test_results.xml
> exists. Not adding test launcher result printer.

Whatever, though, it's only on the bots. Removed.

[Robert Sesek, 2014-04-30 14:04:42]

Ping?

[Robert Sesek, 2014-05-01 12:33:23]

Ping again.

[Paweł Hajdan Jr., 2014-05-05 11:19:28]

LGTM

[Robert Sesek, 2014-05-05 12:32:40]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-05-05 12:32:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/257193002/20001

[commit-bot: I haz the power, 2014-05-05 12:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-05 12:32:56]

Failed to apply patch for testing/buildbot/chromium_trybot.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file testing/buildbot/chromium_trybot.json
  Hunk #1 FAILED at 57.
  1 out of 1 hunk FAILED -- saving rejects to file
testing/buildbot/chromium_trybot.json.rej

Patch:       testing/buildbot/chromium_trybot.json
Index: testing/buildbot/chromium_trybot.json
diff --git a/testing/buildbot/chromium_trybot.json
b/testing/buildbot/chromium_trybot.json
index
34516b39f80b348cb6addf7eb739fc272b7786f0..62b8c4b374cf13faf6d7a3e70d6525985ce9161b
100644
--- a/testing/buildbot/chromium_trybot.json
+++ b/testing/buildbot/chromium_trybot.json
@@ -57,5 +57,9 @@
     "test": "sandbox_linux_unittests",
     "platforms": ["linux"],
     "args": ["--test-launcher-print-test-stdio=always"]
+  },
+  {
+    "test": "sandbox_mac_unittests",
+    "platforms": ["mac"]
   }
 ]

[Robert Sesek, 2014-05-05 13:25:54]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-05-05 13:26:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/257193002/40001

[Robert Sesek, 2014-05-05 13:38:31]

The CQ bit was unchecked by rsesek@chromium.org

[Robert Sesek, 2014-05-05 13:38:55]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-05-05 13:39:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/257193002/60001

[commit-bot: I haz the power, 2014-05-05 21:44:15]

Change committed as 268279