Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: components/webdata/common/web_database_service.cc

Issue 2571923002: Fix threading issues in WebDataRequestManager. (Closed)
Patch Set: fix a comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/webdata/common/web_database_backend.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/webdata/common/web_database_service.cc
diff --git a/components/webdata/common/web_database_service.cc b/components/webdata/common/web_database_service.cc
index 79bc298022c7bed8fd3590bea99cf2f0b7cd553e..41b8e64dbdbd49629daf7839a0c6ae76e5c7e287 100644
--- a/components/webdata/common/web_database_service.cc
+++ b/components/webdata/common/web_database_service.cc
@@ -94,8 +94,8 @@ void WebDatabaseService::ScheduleDBTask(
const tracked_objects::Location& from_here,
const WriteTask& task) {
DCHECK(web_db_backend_.get());
- std::unique_ptr<WebDataRequest> request(
- new WebDataRequest(NULL, web_db_backend_->request_manager().get()));
+ std::unique_ptr<WebDataRequest> request =
+ web_db_backend_->request_manager()->NewRequest(nullptr);
db_thread_->PostTask(
from_here, Bind(&WebDatabaseBackend::DBWriteTaskWrapper, web_db_backend_,
task, base::Passed(&request)));
@@ -107,8 +107,8 @@ WebDataServiceBase::Handle WebDatabaseService::ScheduleDBTaskWithResult(
WebDataServiceConsumer* consumer) {
DCHECK(consumer);
DCHECK(web_db_backend_.get());
- std::unique_ptr<WebDataRequest> request(
- new WebDataRequest(consumer, web_db_backend_->request_manager().get()));
+ std::unique_ptr<WebDataRequest> request =
+ web_db_backend_->request_manager()->NewRequest(consumer);
WebDataServiceBase::Handle handle = request->GetHandle();
db_thread_->PostTask(
from_here, Bind(&WebDatabaseBackend::DBReadTaskWrapper, web_db_backend_,
« no previous file with comments | « components/webdata/common/web_database_backend.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698