Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)
Patch Set: remove the changes to web_ui_mojo.js which seemed to cause flakiness. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js b/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
index 2a73642973109c1ceb3ad19deacc377c2de70fb3..963e40e0ea54420c655f5b31aef76ca54089475d 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
@@ -42,9 +42,9 @@ function mojoMetadataToJS(mojoMetadata) {
let mediaSessionServiceMock = loadMojoModules(
'mediaSessionServiceMock',
['third_party/WebKit/public/platform/modules/mediasession/media_session.mojom',
- 'mojo/public/js/router',
+ 'mojo/public/js/bindings',
]).then(mojo => {
- let [mediaSessionService, router] = mojo.modules;
+ let [mediaSessionService, bindings] = mojo.modules;
MediaSessionAction = mediaSessionService.MediaSessionAction;
MediaSessionPlaybackState = mediaSessionService.MediaSessionPlaybackState;
@@ -53,15 +53,11 @@ let mediaSessionServiceMock = loadMojoModules(
constructor(interfaceProvider) {
interfaceProvider.addInterfaceOverrideForTesting(
mediaSessionService.MediaSessionService.name,
- handle => this.connectMediaSessionService_(handle));
+ handle => this.bindingSet_.addBinding(this, handle));
this.interfaceProvider_ = interfaceProvider;
this.pendingResponse_ = null;
- }
-
- connectMediaSessionService_(handle) {
- this.mediaSessionServiceStub_ = new mediaSessionService.MediaSessionService.stubClass(this);
- this.mediaSessionServiceRouter_ = new router.Router(handle);
- this.mediaSessionServiceRouter_.setIncomingReceiver(this.mediaSessionServiceStub_);
+ this.bindingSet_ = new bindings.BindingSet(
+ mediaSessionService.MediaSessionService);
}
setMetadata(metadata) {

Powered by Google App Engine
This is Rietveld 408576698