Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8463)

Unified Diff: chrome/test/data/webui/plugins_browsertest.js

Issue 2571903003: Mojo JS bindings: switch most usage of "connection"/"router" module to "bindings". (Closed)
Patch Set: Merge branch 'refs/heads/c161_more_bindings_change' into c160_remove_connection_mojo Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/bluetooth_internals_browsertest.js ('k') | content/test/data/web_ui_mojo.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/plugins_browsertest.js
diff --git a/chrome/test/data/webui/plugins_browsertest.js b/chrome/test/data/webui/plugins_browsertest.js
index 6f613ea21067c3a9f2718e18118f8925868694fb..72147f374853b8a913809afc14657e66724ae50b 100644
--- a/chrome/test/data/webui/plugins_browsertest.js
+++ b/chrome/test/data/webui/plugins_browsertest.js
@@ -55,6 +55,8 @@ PluginsTest.prototype = {
'saveShowDetailsToPrefs',
]);
+ this.bindingSet = null;
+
/**
* The data to be returned by |getPluginsData_|.
* @private
@@ -96,20 +98,18 @@ PluginsTest.prototype = {
window.setupFn = function() {
return importModules([
'mojo/public/js/bindings',
- 'mojo/public/js/connection',
'chrome/browser/ui/webui/plugins/plugins.mojom',
'content/public/renderer/frame_interfaces',
]).then(function(modules) {
var bindings = modules[0];
- var connection = modules[1];
- var pluginsMojom = modules[2];
- var frameInterfaces = modules[3];
+ var pluginsMojom = modules[1];
+ var frameInterfaces = modules[2];
+ this.browserProxy.bindingSet = new bindings.BindingSet(
+ pluginsMojom.PluginsPageHandler);
frameInterfaces.addInterfaceOverrideForTesting(
pluginsMojom.PluginsPageHandler.name, function(handle) {
- var stub = connection.bindHandleToStub(
- handle, pluginsMojom.PluginsPageHandler);
- bindings.StubBindings(stub).delegate = this.browserProxy;
+ this.browserProxy.bindingSet(this.browserProxy, handle);
Ken Rockot(use gerrit already) 2016/12/16 16:43:19 nit: addBinding :)
yzshen1 2016/12/16 16:55:08 It scares me a little bit that this doesn't fail t
}.bind(this));
return this.setupFnResolver.promise;
}.bind(this));
« no previous file with comments | « chrome/test/data/webui/bluetooth_internals_browsertest.js ('k') | content/test/data/web_ui_mojo.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698