Issue 2571843002: VM: [DBC] Fix GetDeoptFpOffset in the presence of materializations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2571843002: VM: [DBC] Fix GetDeoptFpOffset in the presence of materializations. (Closed)

Created:
4 years ago by Vyacheslav Egorov (Google)

Modified:
4 years ago

Reviewers:
zra, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: [DBC] Fix GetDeoptFpOffset in the presence of materializations. Number of materializations was not taken into account when computing FP offset on DBC. This fixes flaky crashes on language/vm/optimized_stacktrace_test. R=zra@google.com, rmacnak@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/28046fcf7df87cb11ce93d6cf01abd8cce2a2e27

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/vm/stack_frame.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

4 years ago (2016-12-13 17:53:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
28046fcf7df87cb11ce93d6cf01abd8cce2a2e27 (presubmit successful).