Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2571743003: Revert "Fix border radius on composited children." on 2950 branch (Closed)

Created:
4 years ago by Stephen Chennney
Modified:
4 years ago
Reviewers:
chrishtr
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2950
Project:
chromium
Visibility:
Public.

Description

Revert "Fix border radius on composited children." on 2950 branch This reverts commit https://crrev.com/0cfffd46dfaa1ee93d3d667f82b2fb3721078b34 Chrome's sign-in flow is broken as a result of this patch. Content inside an element with border-radius is not rendering. Reverted review URL: https://codereview.chromium.org/2194273002 TBR=chrishtr@chromium.org BUG=157218, 673668, 673725 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2569253002 Cr-Commit-Position: refs/heads/master@{#438234} (cherry picked from commit ed8391042f4acb62c7c89898e8dad01f8afb79e4) Conflicts: third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 Committed: https://chromium.googlesource.com/chromium/src/+/58d839ef5c55dd8d388137a55a0bdbc8c57673c3

Patch Set 1 : Revert "Fix border radius on composited children." #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -404 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/border-radius-styles-with-composited-child-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/empty-composited-child-of-border-radius-ancestor-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/borders/border-radius-with-composited-child.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-with-composited-child-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/clip/overflow-border-radius-composited-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-with-composited-child-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/clip/overflow-border-radius-composited-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-with-composited-child-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 4 chunks +4 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 16 chunks +20 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp View 4 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 7 chunks +15 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositingReasons.h View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositingReasons.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Stephen Chennney
4 years ago (2016-12-13 19:21:10 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
58d839ef5c55dd8d388137a55a0bdbc8c57673c3.

Powered by Google App Engine
This is Rietveld 408576698