Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2571713005: DevTools: untruncate links on console export (Closed)
Patch Set: up + test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 73aedc4e179d8c807b396adce17e0a2844e34dd4..dc1d2a8c71153b24460d24cde0b5ffb3a4e309b9 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -53,6 +53,17 @@ Console.ConsoleViewMessage = class {
}
/**
+ * @param {!Node} node
+ * @return {string}
+ */
+ static _contentTransform(node) {
+ var originalLinkText = Components.Linkifier.originalLinkText(node.parentElement);
+ if (typeof originalLinkText === 'string')
+ return originalLinkText;
+ return node.textContent;
+ }
+
+ /**
* @return {?SDK.Target}
*/
_target() {
@@ -292,13 +303,17 @@ Console.ConsoleViewMessage = class {
anchorElement = this._linkifyLocation(consoleMessage.url, consoleMessage.line, consoleMessage.column);
}
} else if (consoleMessage.url) {
- anchorElement = Components.Linkifier.linkifyURL(consoleMessage.url, undefined, 'console-message-url');
+ anchorElement = Components.Linkifier.linkifyURL(consoleMessage.url, undefined);
}
// Append a space to prevent the anchor text from being glued to the console message when the user selects and copies the console messages.
- if (anchorElement)
- anchorElement.appendChild(createTextNode(' '));
- return anchorElement;
+ if (anchorElement) {
+ var anchorWrapperElement = createElementWithClass('span', 'console-message-anchor');
+ anchorWrapperElement.appendChild(anchorElement);
+ anchorWrapperElement.createTextChild(' ');
+ return anchorWrapperElement;
+ }
+ return null;
}
/**
@@ -356,7 +371,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, 'console-message-url');
+ return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber);
}
/**
@@ -367,7 +382,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace, 'console-message-url');
+ return this._linkifier.linkifyStackTraceTopFrame(target, stackTrace);
}
/**
@@ -381,8 +396,7 @@ Console.ConsoleViewMessage = class {
var target = this._target();
if (!target)
return null;
- return this._linkifier.linkifyScriptLocation(
- target, scriptId, url, lineNumber, columnNumber, 'console-message-url');
+ return this._linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber, columnNumber);
}
/**
@@ -1091,6 +1105,17 @@ Console.ConsoleViewMessage = class {
}
/**
+ * @return {string}
+ */
+ toExportString() {
+ var lines = [];
+ var messageContent = this.contentElement().deepTextContent(Console.ConsoleViewMessage._contentTransform);
+ for (var i = 0; i < this.repeatCount(); ++i)
+ lines.push(messageContent);
+ return lines.join('\n');
+ }
+
+ /**
* @param {?RegExp} regex
*/
setSearchRegex(regex) {

Powered by Google App Engine
This is Rietveld 408576698